Skip to content

Never calling session.restartPolling() which means a tag miss is unrecoverable #280

Open

Description

@antpuleo2586

Hi

Great library and thanks for your hard work on it.

I'm using it in an expo module for react native and it's mostly working great.

But there is sometimes an issue whereby a missed scan never recovers and I have to wait for the session to fail and try again.

From what I understand, we can call restartPolling within the same session to discover a new tag, if it was previously missed.

I have patched your library locally to try to recover when a tag has been received but dropped using restartPolling in this block:

https://github.com/AndyQ/NFCPassportReader/blob/main/Sources/NFCPassportReader/PassportReader.swift#L184

It seems to work well and I'm not getting the failures I was previously.

My knowledge of swift, CoreNFC and passport scanning in general is fairly limited so it would be great to know what you think.

Thanks

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions