Fix test where there could be either a parking machine or a parking zone - #66
Merged
Merged
Conversation
RikSchefferAmsterdam
requested review from
a team
and
a lite review from Copilot
September 10, 2026 09:26
RikSchefferAmsterdam
enabled auto-merge
September 10, 2026 09:27
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The non-paid completed-session path must also handle parking-machine sessions.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates shared Maestro parking session-detail tests to support either a parking machine or permit zone.
Changes:
- Adds conditional permit-zone assertions for active and paid completed sessions.
- Normalizes YAML formatting and quoting.
File summaries
| File | Summary |
|---|---|
maestro/parking/shared/session-details.yaml |
Adjusts location-row assertions; the non-paid completed-session path still unconditionally requires the permit-zone row. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
github-actions
Bot
added
the
Copilot ready
WouterAms
approved these changes
Sep 14, 2026
github-actions
Bot
added
the
Code reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates shared Maestro parking session-detail tests to support either a parking machine or permit zone.
Changes:
File summaries
maestro/parking/shared/session-details.yamlTest instructions
Other notes
GitHub Copilot was used in writing the code