Boat-charging: add visitor start session - #60
Open
RikSchefferAmsterdam wants to merge 4 commits into
Open
Conversation
RikSchefferAmsterdam
requested review from
a team
and
a lite review from Copilot
August 14, 2026 12:21
RikSchefferAmsterdam
force-pushed
the
feature/add-boat-charging-visitor
branch
from
August 14, 2026 12:22
672c5ed to
0e55b08
Compare
RikSchefferAmsterdam
enabled auto-merge
August 14, 2026 12:22
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Maestro E2E scenario for Boat Charging (visitor flow) and extends CI credential injection to support Boat Charging + VCPS configuration across platforms.
Changes:
- Extend Azure DevOps pipeline templating to inject Boat Charging secrets/config into Maestro
credentials.js. - Add Boat Charging “visitor start/stop session” Maestro entry flow plus supporting VCPS helper flows.
- Introduce platform-selection script for VCPS config (Android vs iOS), along with a couple of experimental scripts.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pipelines/templates/shared.yml | Consolidates sed injections and adds Boat Charging variables for CI placeholder replacement. |
| maestro/scripts/credentials.ci.js | Adds Boat Charging/VCPS placeholders to the credentials output object. |
| maestro/boat-charging/entry/visitor.entry.yaml | New end-to-end Boat Charging visitor flow (start + stop session). |
| maestro/boat-charging/scripts/select-vcps.js | Selects platform-specific VCPS variables at runtime (Android/iOS). |
| maestro/boat-charging/vcps/open-vcps.yaml | Opens VCPS link and inputs session/station configuration. |
| maestro/boat-charging/vcps/turn-vcps-on.yaml | Ensures VCPS is turned on before simulating cable actions. |
| maestro/boat-charging/vcps/plug-cable-in-vcps.yaml | Simulates plugging the cable in via VCPS UI. |
| maestro/boat-charging/vcps/unplug-cable-vcps.yaml | Simulates unplugging the cable via VCPS UI. |
| maestro/boat-charging/vcps/back-to-app.yaml | iOS-only navigation back from VCPS to the app. |
| maestro/boat-charging/scripts/t.js | Experimental networking script (currently unused). |
| maestro/boat-charging/scripts/plugInSocket.js | Experimental WebSocket script (currently unused). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+43
to
+59
| -e 's|__BOAT_CHARGING_EMAIL__|$(BOAT_CHARGING_EMAIL)|g' \ | ||
| -e 's|__BOAT_CHARGING_PASSWORD__|$(BOAT_CHARGING_PASSWORD)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_URL__|$(BOAT_CHARGING_VCPS_URL)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_ENDPOINT__|$(BOAT_CHARGING_VCPS_ENDPOINT)|g' \ | ||
| -e 's|__BOAT_CHARGING_CHARGING_LOCATION_IOS__|$(BOAT_CHARGING_CHARGING_LOCATION_IOS)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_SESSION_NAME_IOS__|$(BOAT_CHARGING_VCPS_SESSION_NAME_IOS)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_STATION_ID_IOS__|$(BOAT_CHARGING_VCPS_STATION_ID_IOS)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_MODEL_TYPE_IOS__|$(BOAT_CHARGING_VCPS_MODEL_TYPE_IOS)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_CONNECTORS_IOS__|$(BOAT_CHARGING_VCPS_CONNECTORS_IOS)|g' \ | ||
| -e 's|__BOAT_CHARGING_SOCKET_IOS__|$(BOAT_CHARGING_SOCKET_IOS)|g' \ | ||
| -e 's|__BOAT_CHARGING_CHARGING_LOCATION_ANDROID__|$(BOAT_CHARGING_CHARGING_LOCATION_ANDROID)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_SESSION_NAME_ANDROID__|$(BOAT_CHARGING_VCPS_SESSION_NAME_ANDROID)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_STATION_ID_ANDROID__|$(BOAT_CHARGING_VCPS_STATION_ID_ANDROID)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_MODEL_TYPE_ANDROID__|$(BOAT_CHARGING_VCPS_MODEL_TYPE_ANDROID)|g' \ | ||
| -e 's|__BOAT_CHARGING_VCPS_CONNECTORS_ANDROID__|$(BOAT_CHARGING_VCPS_CONNECTORS_ANDROID)|g' \ | ||
| -e 's|__BOAT_CHARGING_SOCKET_ANDROID__|$(BOAT_CHARGING_SOCKET_ANDROID)|g' \ | ||
| {} + |
Comment on lines
+52
to
+53
| # TODO: the next step should be replaced by opening the app again, but for now we just go back to the app which only works on iOS | ||
| - runFlow: ../vcps/back-to-app.yaml |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Test instructions
Other notes
GitHub Copilot was used in writing the code