Skip to content

[PWGCF] Fix O2-linter errors#16104

Merged
SwatiSaha-1997 merged 1 commit intoAliceO2Group:masterfrom
SwatiSaha-1997:master
May 4, 2026
Merged

[PWGCF] Fix O2-linter errors#16104
SwatiSaha-1997 merged 1 commit intoAliceO2Group:masterfrom
SwatiSaha-1997:master

Conversation

@SwatiSaha-1997
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix O2-linter errors [PWGCF] Fix O2-linter errors May 4, 2026
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 4, 2026

Duplicate of #16084. Please don't do that.

@SwatiSaha-1997
Copy link
Copy Markdown
Collaborator Author

Dear @vkucera, I won't from next time.
Since, the build/O2Physics/o2/macOS-arm failed for that PR twice. So, i tried to do it freshly, and updated my repository with the origin, and that resulted in closing the previous commit. So, i opened this one again.

@SwatiSaha-1997 SwatiSaha-1997 enabled auto-merge (squash) May 4, 2026 19:39
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @SwatiSaha-1997.

@SwatiSaha-1997 SwatiSaha-1997 merged commit 33f257b into AliceO2Group:master May 4, 2026
12 of 13 checks passed
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 4, 2026

Dear @vkucera, I won't from next time. Since, the build/O2Physics/o2/macOS-arm failed for that PR twice. So, i tried to do it freshly, and updated my repository with the origin, and that resulted in closing the previous commit. So, i opened this one again.

You still have two warnings.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 4, 2026

Dear @vkucera, I won't from next time. Since, the build/O2Physics/o2/macOS-arm failed for that PR twice. So, i tried to do it freshly, and updated my repository with the origin, and that resulted in closing the previous commit. So, i opened this one again.

It's fine to update your repository but it is always possible to update the current pull request.

@SwatiSaha-1997
Copy link
Copy Markdown
Collaborator Author

Dear @vkucera, I won't from next time. Since, the build/O2Physics/o2/macOS-arm failed for that PR twice. So, i tried to do it freshly, and updated my repository with the origin, and that resulted in closing the previous commit. So, i opened this one again.

You still have two warnings.

Dear @vkucera , I will fix these two warnings in the next commit.

@SwatiSaha-1997
Copy link
Copy Markdown
Collaborator Author

Dear @vkucera, I won't from next time. Since, the build/O2Physics/o2/macOS-arm failed for that PR twice. So, i tried to do it freshly, and updated my repository with the origin, and that resulted in closing the previous commit. So, i opened this one again.

It's fine to update your repository but it is always possible to update the current pull request.

Dear @vkucera, yes but I used this 'git reset --hard upstream/master'. It updated my local repo with the original O2Physics.

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented May 4, 2026

Dear @vkucera, I won't from next time. Since, the build/O2Physics/o2/macOS-arm failed for that PR twice. So, i tried to do it freshly, and updated my repository with the origin, and that resulted in closing the previous commit. So, i opened this one again.

It's fine to update your repository but it is always possible to update the current pull request.

Dear @vkucera, yes but I used this 'git reset --hard upstream/master'. It updated my local repo with the original O2Physics.

Well, that is obviously a wrong way to do it. This command makes your current branch identical to upstream/master.

@SwatiSaha-1997
Copy link
Copy Markdown
Collaborator Author

SwatiSaha-1997 commented May 4, 2026

Dear @vkucera, I won't from next time. Since, the build/O2Physics/o2/macOS-arm failed for that PR twice. So, i tried to do it freshly, and updated my repository with the origin, and that resulted in closing the previous commit. So, i opened this one again.

It's fine to update your repository but it is always possible to update the current pull request.

Dear @vkucera, yes but I used this 'git reset --hard upstream/master'. It updated my local repo with the original O2Physics.

Well, that is obviously a wrong way to do it. This command makes your current branch identical to upstream/master.

Dear @vkucera, i was thinking that the macOs build error in my PR appeared due to some mistake on my side (all other PRs opened before and after mine passed that, although the error was not related to the code which was changed in my PR). So, i wanted my repo to match the original O2Physics, and then retry the commit, and was hoping that the build error gets resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants