[PWGLF] timing cuts, post-processing update#16058
[PWGLF] timing cuts, post-processing update#16058romainschotter merged 8 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#16058
nepeivodaRS
requested review from
alibuild,
ercolessi,
lhusova,
mpuccio,
omvazque,
romainschotter and
skundu692
as code owners
| #include "PWGLF/DataModel/LFStrangenessTables.h" | ||
| #include "PWGLF/DataModel/cascqaanalysis.h" | ||
|
|
||
| #include <Framework/AnalysisHelpers.h> | ||
| #include <Framework/AnalysisTask.h> | ||
| #include <Framework/Configurable.h> | ||
| #include <Framework/HistogramRegistry.h> | ||
| #include <Framework/HistogramSpec.h> | ||
| #include <Framework/InitContext.h> | ||
| #include <Framework/O2DatabasePDGPlugin.h> | ||
| #include <Framework/runDataProcessing.h> | ||
| #include "Common/DataModel/EventSelection.h" | ||
| #include "Common/DataModel/TrackSelectionTables.h" | ||
|
|
||
| #include <TH1.h> | ||
| #include <TMath.h> | ||
| #include <TMathBase.h> | ||
| #include <TString.h> | ||
| #include "Framework/AnalysisTask.h" | ||
| #include "Framework/runDataProcessing.h" | ||
| #include <CommonConstants/PhysicsConstants.h> |
There was a problem hiding this comment.
@nepeivodaRS How did you come up with this?
@romainschotter How did this get approved?
There was a problem hiding this comment.
@vkucera Hi, what is the issue here exactly? This cleanup was done to satisfy the o2linter errors. Is there something wrong with the change?
There was a problem hiding this comment.
- Which errors exactly? O2 linter does not tell you to add or remove framework includes.
- This is not a cleanup. This is just reverting my fixes made in [PWGLF] Fix includes and using statements #15388.
There was a problem hiding this comment.
Now I see what you mean. Sorry, I didn’t get it at first.
I've been modifying this task locally for the derived data analysis and have not been pushing those local changes, since I do not use this version on hyperloop. When preparing this PR, I pushed my local version and missed that it reverted your include changes.
This was not intentional. I can prepare a PR to restore your include structure if needed.
There was a problem hiding this comment.
Thanks a lot, and sorry again for the confusion.
4 participants
Timing cuts and cascade post-processing cleanup.