Repository navigation
fix(issue-forms): remove invalid empty title keys - #1524
Merged
ErikBjare merged 2 commits intoOct 13, 2026
Merged
Conversation
Contributor
|
TimeToBuildBob
approved these changes
Oct 13, 2026
TimeToBuildBob
left a comment
Contributor
There was a problem hiding this comment.
Verified against the GitHub issue-forms schema (SchemaStore vendor.github-issue-forms via check-jsonschema):
- current
master: fails on both forms with$.title: '' should be non-empty, the error @rakleed reported - this branch:
ok -- validation donefor bothbug-report.ymlandeverything-else.yml
labels (type: bug) exists in the repo, and no other changes are needed. The greeting failure is the first-time-contributor workflow and has nothing to do with this diff. LGTM, ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #1482 migrated the templates to GitHub Issue Forms, both
.github/ISSUE_TEMPLATE/bug-report.ymland.github/ISSUE_TEMPLATE/everything-else.ymlretained an emptytitle: ""key. GitHub rejects that value (titlemust be a non-empty string), which prevents the forms from appearing correctly in the issue chooser.Fix
Remove the optional
titlekey from both forms. Keep all other fields, validation requirements, labels, and the support-forum link unchanged.Verification
master: 2 files changed, 0 additions, 2 deletions.nameandbodyand neither contains an emptytitlekey.Credit / provenance
Refs #1464, #1482.