Skip to content

fix(issue-forms): remove invalid empty title keys - #1524

Merged
ErikBjare merged 2 commits into
ActivityWatch:masterfrom
kvnloo:fix/issue-forms-empty-title-1464
Oct 13, 2026
Merged

ErikBjare merged 2 commits into
ActivityWatch:masterfrom
kvnloo:fix/issue-forms-empty-title-1464

Conversation

@kvnloo

@kvnloo kvnloo commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Problem

After #1482 migrated the templates to GitHub Issue Forms, both .github/ISSUE_TEMPLATE/bug-report.yml and .github/ISSUE_TEMPLATE/everything-else.yml retained an empty title: "" key. GitHub rejects that value (title must be a non-empty string), which prevents the forms from appearing correctly in the issue chooser.

Fix

Remove the optional title key from both forms. Keep all other fields, validation requirements, labels, and the support-forum link unchanged.

Verification

  • Compared the branch against current upstream master: 2 files changed, 0 additions, 2 deletions.
  • Confirmed each form still has name and body and neither contains an empty title key.
  • Live issue-chooser behavior can be verified after merge.

Credit / provenance

Refs #1464, #1482.

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Removes title: "" from both GitHub issue forms.

  • GitHub can show both issue forms without an empty title.

Reviews (1) · Last reviewed commit: "fix(issue-forms): omit empty optional ti..." · Reviewed by Greptile

@TimeToBuildBob TimeToBuildBob left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against the GitHub issue-forms schema (SchemaStore vendor.github-issue-forms via check-jsonschema):

  • current master: fails on both forms with $.title: '' should be non-empty, the error @rakleed reported
  • this branch: ok -- validation done for both bug-report.yml and everything-else.yml

labels (type: bug) exists in the repo, and no other changes are needed. The greeting failure is the first-time-contributor workflow and has nothing to do with this diff. LGTM, ready to merge.

@TimeToBuildBob TimeToBuildBob mentioned this pull request Oct 13, 2026
2 tasks done
@ErikBjare
ErikBjare merged commit 33f667d into ActivityWatch:master Oct 13, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants