Repository navigation
fix: normalise entity_type when resolving draft note links on publish - #223
Merged
Merged
Conversation
ENTITY_MODELS is keyed lowercase but links carry the capitalized type
from search results ("Shot"), so every user-added link was silently
dropped before reaching the provider. Present since v0.1.8 (#71).
Closes #222
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Cameron Target <camerontarget@gmail.com>
update_note had no links parameter, so a link added after the first publish never reached ShotGrid. Links are merged into the note's existing note_links rather than replacing them, so links added by hand in ShotGrid survive a republish. Refs #222 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Cameron Target <camerontarget@gmail.com>
camerontarget14
added a commit
to jspada200/dna
that referenced
this pull request
Oct 9, 2026
Resolve conflicts with AcademySoftwareFoundation#223 (draft note links on publish): adopt the new _draft_note_links/_add_context_links helpers and update_note links support, adapted to string IDs (SCRATCH_VERSION_ID sentinel, _to_sg_id at the ShotGrid boundary). Tests from AcademySoftwareFoundation#223 updated to string fixtures. Signed-off-by: Cameron Target <camerontarget@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENTITY_MODELS is keyed lowercase but links carry the capitalized type from search results ("Shot"), so every user-added link was silently dropped before reaching the provider. Present since v0.1.8 (#71).
Closes #222
Also made sure link additions were reflected in notes from republishes too.