Repository navigation
Conversation
…#3432) The hand-written fixture DDL lacked the chain_depth column that #3120 added to SchedulerDatabase.create_execution, so every agent-path INSERT in the scheduler tier raised OperationalError (70 failed / 173 passed). With the column: 3 failed / 240 passed; the remaining three are a separate drift (claim_token), left out of this fixture-only commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eduler source (#3432) The scheduler still created process_schedules / process_schedule_executions at boot, re-read them every sync tick, and executed rows by POSTing to /api/processes/{id}/execute, a route the backend lost in #430. Nothing can create a row. Removed: the boot DDL, the snapshot + sync, the job add/remove/execute path, the skipped-execution recorder and its max-instances branch, the database section, the two models, the stranded _INTEGRITY_ERRORS import. The two tables are left in place on existing installs (no migration). The agent-schedule path, its lock-denial audit (#1969/#1808) and reminder machinery (#1296) are unchanged; the _on_job_max_instances unknown-prefix warning stays (reminder jobs share the listener). Red-first tests: test_legacy_process_schedule_tables_are_ignored (an enabled legacy row registered process_schedule_ps-legacy at HEAD) and test_on_job_max_instances_legacy_process_prefix_is_unknown (the legacy id reached _record_skipped_process_schedule at HEAD). Tests that exercised the removed identifiers are deleted or re-pinned in this commit: test_1994 deleted, process cases cut from test_skipped_executions / test_1474 / test_sync_loop, test_1296's ensure_process_schedules_table call dropped, test_1969's slice end re-anchored on `async def _execute_schedule(`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…schedule writer (#3432) test_1832 narrated three duration writers (one was the deleted process_schedule_executions finalizer); test_1823 pointed at the deleted test_1994 as its structural model, now test_1969. Docstrings only; the scanner logic is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… process-schedule remnant (#3432) - tests/run-core.sh and both nightly workflows drop --ignore=process_engine (the directory no longer exists); the workflow comments stop citing a run-core.sh line number. - test_1896's literal --ignore=process_engine assertion becomes a parity check: the workflow's --ignore set must equal run-core.sh's (red with run-core.sh edited alone, green once both sides match). - scheduler-service.md: Flow 3 (process execution) removed and Flows 4-10 renumbered 3-9; process sync, events, max-instances branch, DB operations and method rows removed; revision history entry added. - requirements/scheduling.md, architecture/execution.md: the scheduler has one duration finalizer, not two. - architecture/database.md: the two tables are recorded as orphans left on upgraded installs (no migration). - architecture.md Invariant #16: "+ process-schedule variants" removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#3433) The hand-written fixture DDL lacked the claim_token column (TEXT, as in db/schema.py) that SchedulerDatabase's require_unclaimed guard (#2514) reads, leaving three scheduler tests red: test_1472::test_a2_dispatch_exception_advances_next_run and two in test_async_dispatch. With the column: 243 passed, 0 failed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…exclusion (#3432) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 9, 2026
Contributor
Author
|
Two additions to Before merge since this PR opened:
|
…-process-schedule-removal # Conflicts: # tests/scheduler_tests/conftest.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3432. One of five independent stale-code PRs off
dev; sibling #3433's branch (dead symbols) touches the same scheduler files and test-merges clean against this one. Draft: the issue asks for this to land after the 1.0 release is cut, and before #3433's PR.What
src/scheduler/service.py,database.py,models.py, a comment inconfig.py: the process-schedule half is gone. No table creation at boot, no snapshot re-read each sync tick, no execute path posting to the removed/api/processes/{id}/executeroute, noprocess_schedule_execution_*events, noProcessSchedule/ProcessScheduleExecutionmodels.git grep -n process_schedule src/is empty.dev, including the lock-denial audit (bug: cron tick suppressed by distributed lock leaves no execution record #1969/freeze_schedules_if_sync_failing is never enforced — schedules keep firing while sync is failing (safety toggle is inert) #1808), skipped-run recording (bug(scheduler): _execute_process_schedule lock-denial branch still unaudited (sibling of #1969) #1994) and reminder reconcile (feat: agent self-reminders — agent-callable one-shot deferred self-trigger ("remind me to do X later") #1296).tests/unit/test_1994_process_schedule_lock_audit.pydeleted; process cases cut fromtest_skipped_executions.py,test_1474_timestamp_z_suffix.py,test_sync_loop.py,test_1296_reminders.py;test_1969re-anchored. Two new guards: a database that still holds the legacy tables registers no process job, and a persisted legacy job id falls to the unknown-prefix warning.chain_depthandclaim_tokencolumns the hand-writtenschedule_executionsDDL intests/scheduler_tests/conftest.pylacked. Ondevthat fixture drift fails 70 of 243 scheduler tests, and no CI workflow runs that tier. refactor: remove about 50 backend and scheduler symbols that no production code references #3433's branch carries the identical two commits.--ignore=process_engineremoved fromtests/run-core.shand both nightly workflows;test_1896now asserts thatrun-core.shand the workflows pass the same ignore set.scheduler-service.md(Flow 3 removed, Flows 4–10 renumbered 3–9),requirements/scheduling.md,architecture/execution.md,architecture/database.md(the two orphan tables), Invariant #16 wording inarchitecture.md,docs/testing/STRATEGY.md,testing-agents.md.Rulings carried (orchestrator, on the operator's behalf — plan file)
database.md; a drop would be undone by any older scheduler image that recreates them at boot.test_1896).tests/test_access_control.pyprocess-engine classes are left to refactor: remove the Process Engine remnants (unmounted docs router, config/process-docs, process/ components, manual process YAMLs) #2491.Review + security
/review(reading review, report-only): MERGEABLE, no critical findings. Completeness, schema, workflow YAML and doc renumbering checks all hold; thetest_1896parity assertion was proven to fail when either side gains an extra flag./cso --diff: no findings, net surface reduction (one header-less outbound POST removed). Fixed after review: the two staleSTRATEGY.mdrows and theclaim_tokenfixture column.Tests
tests/scheduler_tests: 241 passed, 0 failed (70 failed ondevbefore the fixture commits).dev's scheduler source, both new guard tests fail on their own assertions.git merge-treeagainstdevand against refactor: remove about 50 backend and scheduler symbols that no production code references #3433's branch: clean.Before merge
Handoffs
src/backend/services/process_engine/directory (audit-trail.md,execution-list-page.md,alerts-page.md,AUDIT_TRAIL_ARCHITECTURE.md,02-service-architecture.md) are outside this issue — docs: memory-doc drift — architecture.md lists 2 deleted modules, 9 flow docs describe removed surfaces, 26 point at moved paths, index hygiene #2494.🤖 Generated with Claude Code