Skip to content

fix blurry rotations (issue #24) by filling all 4 images from unrotat… - #25

Open
XiaNi wants to merge 1 commit into
AR-js-org:devfrom
XiaNi:fix-generated-blurred-rotations
Open

XiaNi wants to merge 1 commit into
AR-js-org:devfrom
XiaNi:fix-generated-blurred-rotations

Conversation

@XiaNi

@XiaNi XiaNi commented Mar 4, 2020

Copy link
Copy Markdown

fix blurry rotations (issue #24) by filling all 4 images from unrotated but in different order

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce?

Can it be referenced to an Issue? If so what is the issue # ?
#24

How can we test it?
generate file and checkout

Summary
it should improve marker detection (i hope)

Does this PR introduce a breaking change?
no

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser

Other information

@kalwalt kalwalt added enhancement New feature or request pattern generation issues concerning pattern generation pattern marker about pattern markers labels Mar 4, 2020
@kalwalt kalwalt self-assigned this Mar 16, 2020
@kalwalt

kalwalt commented Mar 16, 2020

Copy link
Copy Markdown
Member

@XiaNi I will look into this very soon! We have released v. 3.0.0 so i will have more time to test your PR.

@kalwalt

kalwalt commented Mar 20, 2020

Copy link
Copy Markdown
Member

@XiaNi How can i test this? How do you visualize the pattern file?

@XiaNi

XiaNi commented Mar 21, 2020

Copy link
Copy Markdown
Author

@kalwalt Check here, right side of marker there will be stripe with preview.
( i used "zoom: 2; image-rendering: pixelated;" on canvas, so better check it out on chrome, or if you on firefox then just replace "pixelated" with "crisp-edges", or remove "zoom")

old generator
new generator

@kalwalt

kalwalt commented Mar 21, 2020

Copy link
Copy Markdown
Member

@XiaNi thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request pattern generation issues concerning pattern generation pattern marker about pattern markers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants