(DRAFT) Merge schwarzschild metric files into development#128
Open
cellio00 wants to merge 24 commits into
Open
(DRAFT) Merge schwarzschild metric files into development#128cellio00 wants to merge 24 commits into
cellio00 wants to merge 24 commits into
Conversation
…d of interpolate_rhs_from_mesh to use Metric.H
…ack to the previous prescription.
srichers
requested changes
Jun 24, 2026
srichers
left a comment
srichers
left a comment
Collaborator
There was a problem hiding this comment.
Before reviewing further, it would be good to have a relativistic test problem implemented.
I will be trying to get Debraj's metric branch pulled in so the merge diff should be smaller soon.
Collaborator
There was a problem hiding this comment.
I would prefer not to commit notebooks - storing the metadata is very heavy and version control is difficult.
| // Getting the lower bounds of the domain | ||
| const auto plo = geom.ProbLoArray(); | ||
| // Getting the upper bounds of the domain | ||
| const auto p_hi = geom.ProbHiArray(); |
Collaborator
There was a problem hiding this comment.
can we have the plo and phi variables match (either with or without underscores)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.