Skip to content

allow Embiggen.cpp script to allow domain extension in y (theta) direction without shifting amr levels. - #3357

Merged
zingale merged 12 commits into
AMReX-Astro:developmentfrom
zhichen3:xrb_embiggen
Jul 28, 2026
Merged

allow Embiggen.cpp script to allow domain extension in y (theta) direction without shifting amr levels.#3357
zingale merged 12 commits into
AMReX-Astro:developmentfrom
zhichen3:xrb_embiggen

Conversation

@zhichen3

Copy link
Copy Markdown
Collaborator

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale

zingale commented Jul 27, 2026

Copy link
Copy Markdown
Member

is this ready for review?

@zhichen3

Copy link
Copy Markdown
Collaborator Author

I think its good last time I checked it. I'll read it over this afternoon and make it ready for review if ready.

@zhichen3
zhichen3 marked this pull request as ready for review July 28, 2026 15:13
@zingale
zingale merged commit a540eb8 into AMReX-Astro:development Jul 28, 2026
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants