BUILD: Expose skip-tests and skip-web-performance on the Publish workflow - #342
Merged
Conversation
Passes through the new common-ci nightly-publish input so a package can be released when the test matrix is red for a reason unrelated to the package itself. Deliberately not wired into nightly-pipeline.yml - the nightly should always test.
The web performance test is the only part of the Windows job that fails on the 4.6 data file, and it fails on server startup rather than on a result, so skipping just it leaves the console performance test and the whole integration suite in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Publish run for 4.5.121 failed with three of four platforms green. The Windows job's only failure was the web performance test, which never got a response from the server it starts: the fixed
curl --retry 10wait in common-ci'sscripts/httpbench.ps1is now shorter than the time needed to load the 4.6 data file at 7.72 GB. The console performance test and the whole integration suite passed on the same job, andPackagewas skipped, so no package shipped.What changed
publish.ymlexposesskip-testsandskip-web-performanceand passes them to the shared workflow. Both default tofalse.ci/run-performance-tests.ps1skips the web performance test whenSKIP_WEB_PERFORMANCEistrue, leaving the console performance test in place.Deliberately not wired into
nightly-pipeline.yml- the nightly should always test.Depends on
51Degrees/common-ci#227, which adds the two inputs.
publish.ymlusesnightly-publish.yml@mainand that ref cannot be an expression, so neither input does anything here until that lands.How it was tested
Not exercised in CI, for the reason above. The YAML parses and
ci/run-performance-tests.ps1parses clean.Both inputs are workarounds. The retry budget in
httpbench.ps1is the real bug and is being raised separately.