01a09c37 - About me on the owner, member, and view cards - #183
Closed
TaprootFreakAI wants to merge 31 commits into
Closed
TaprootFreakAI wants to merge 31 commits into
TaprootFreakAI wants to merge 31 commits into
Conversation
TaprootFreakAI
changed the title
TaprootFreakAI
force-pushed
the
01a09c37-profile-activity
branch
5 times, most recently
from
September 14, 2026 12:38
3ab2785 to
1527f06
Compare
Signed-in profile, member, and view cards read the activity payload instead of house-gift stats with Given hardcoded to zero.
Mock-api and Playwright stubs serve given/received activity. Chart globs avoid slash-star so e2e:check does not treat them as comments. Snapshot files exist for screenshot:check; Linux Chromium should regenerate them.
Owners can edit or fill an empty prompt. Member and view cards show the bio in the identity card, with a copy-profile-link and a Message button on the member card rather than on a post.
Profile chart e2e stubs /me/activity instead of gift stats. Unit fixtures include chf/eur/php on spend days and drop GiftStats-only byRecipient.
The identity card now shows About me, copy-profile-link, and Message, so the Linux Chromium snapshots for profile, member, and view need the new pixels.
Icon-only Edit/Save/Cancel/Copy and Message must be reachable by accessible name and must not render the catalog string as visible text.
The binary conflict on screen-profile-desktop-dark-linux.png kept develop's number-format shot. Put the About me baseline back; remaining Linux profile/view shots already matched. Number-format plus About me will refresh from Linux visual actuals after CI.
Keep number format last on /profile. Drop the members overlay-address state; Translate stays on feed posts, not on About me.
Treat a missing-requirements throw from GET /members/:id/activity like the profile fetch. Handbook and UI inventory now list About me, location, and MemberProfileScreen on the activity chart.
Keep-both after location landed: owner accounts include aboutMe, and member/view screens pass donated alongside received.
putAboutMe rethrows errors other than MissingRequirementsError so the About me section can show Could not save. Please try again.
After location landed on develop the member posts-feed overlay case failed schema parse without location on GET /me and GET /members/:id.
The profile chart reads GET /me/activity, not gift stats. Point the populated CHF-tick case at the same activity stub as the USD ticks.
Linux Chromium shots now include FiatPicker on the activity chart together with About me on the identity card.
The owner empty About me control is a sentence-length Button, not an in-card IconButton. Put it in the labeled column of both control tables.
Match NameForm and LocationForm so iOS Safari does not zoom the textarea. Loader comments and member-card recipes follow the code order.
Profile, member, and view shots now include FiatPicker and About me on the current visual grammar.
Ignore MissingRequirementsError when the session changed mid-save. PUT /me/about on the mock API returns 409 without a name. Catalog filled, editing, and save-error About me variants on the owner card.
getByLabel('About me') matched both the textarea and Save About me.
Use the textbox role. Replace placeholder Linux snapshots for filled
and save-error from CI actuals; editing still waits for the next run.
Rebase onto develop's 1-sat reply gifts and convictions. About me stays on the identity card. Gift pay on a member profile opens the posts feed instead of a pinned bio. Overlay-address snapshots on /members stay gone.
TaprootFreakAI
force-pushed
the
01a09c37-profile-activity
branch
from
September 14, 2026 16:33
d6fd139 to
f16ba47
Compare
The editor textbox locator now matches; replace the placeholder screen-profile copies with Playwright actuals from the visual jobs.
Keep-both glued the 1-sat reply composer sentence onto Inputs. CONTRIBUTING requires Purpose, Inputs, Actions, and Used by as separate bullets.
Collaborator
Author
|
EN: DE: Details#184 is merged on develop. Rebase this branch onto current develop before continuing About me (card bio, edit control, copy-link and Message on the card). Do not re-land the activity chart wiring. |
Collaborator
Author
|
EN: DE: DetailsReplacement: #184 (merged). Unique About me work (card bio, edit control, copy-link and Message) remains on |
TaprootFreakAI
changed the title
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
Puts About me inside the identity card on owner, member, and public view profiles. Owners get a pencil editor (NameForm pattern); unfilled prompts “Tell others who you are.” Copy is a link to this profile, not a forum-post link. Message sits on the member card.
DE:
About me sitzt in der Identitätskarte auf Owner-, Member- und View-Profil. Owner bekommen den Stift-Editor (NameForm-Muster); unausgefüllt fordert “Tell others who you are.” Copy ist ein Link zu diesem Profil, kein Forum-Post-Link. Message sitzt auf der Member-Karte.
Details
Keep-both rebase onto current develop after given/received activity landed in #184. This PR does not re-land the activity chart. Bio is not a ForumBoard post. Unfilled is
aboutMe === null(empty, name-copy, or text equal to stored note name). Owner textarea istext-base. 409 missingnamestays on/profile; redirect/setup/rulesonly whenerr.missing.includes('rules'). Gift pay on the member profile opens the posts feed then Send Bitcoin. Overlay-address is restored because the overlay is reachable from posts-feed reply.