01a10b01 - Add member habits with comments and Bitcoin invoices by TaprootFreakAI · Pull Request #399 · 21gifts/api

TaprootFreakAI · 2026-10-05T11:07:49Z

EN:
Any signed-in member can add, edit, archive, and rate their own daily or weekly habit, with the public wording kept on the period it belonged to and private notes returned only to the owner.
A week becomes ratable at 08:00 on the following Monday in the habit's time zone, and daily habits can be rated through today.
Comments, comment deletion, and a Bitcoin invoice for someone else's comment use the existing Sunday pause, and the API does not pay the invoice.
Deploy this API before the app, and pass the SQL habit store from boot into the server so a restart does not drop habits.

DE:
Jedes angemeldete Mitglied kann eine eigene tägliche oder wöchentliche Gewohnheit anlegen, ändern, archivieren und bewerten, wobei der öffentliche Wortlaut am Zeitraum bleibt und private Notizen nur die Person sieht, der die Gewohnheit gehört.
Eine Woche wird am folgenden Montag um 08:00 in der Zeitzone der Gewohnheit bewertbar, und tägliche Gewohnheiten können bis heute bewertet werden.
Kommentare, das Löschen von Kommentaren und eine Bitcoin-Rechnung für den Kommentar einer anderen Person nutzen die bestehende Sonntagspause, und die API bezahlt die Rechnung nicht.
Diese API vor der App ausrollen und den SQL-Speicher aus dem Boot an den Server geben, damit ein Neustart die Gewohnheiten nicht verliert.

Details

Habits are stored in member_habit, member_habit_revision, member_habit_log, and member_habit_comment. Adding a habit and editing its wording each use one SQL statement, so a failure cannot leave the habit row without the revision that belongs to that write. Cadence is chosen at creation and does not change. The habit stores the IANA time zone from the Time-Zone header on add.

Public list is GET /habits. Writes are POST /habits: add, edit, archive, log (achieved, partial, missed), comment, delete comment, and invoice. Add returns the new id. A comment post does not return an id. The invoice response is { pr, amountSats }, with the same 10_000_000 sat ceiling and the same Too many payments limit as a forum gift. Acceptance criteria: https://github.com/21gifts/intern/issues/43. A missing Lightning address uses the existing wallet sentence, not the forum note's "This message cannot be paid yet", because a habit comment has no Nostr event. The status is 409 because 400 on this route is the amount error. Donating to one's own comment is a different job from refusing to message oneself, so that sentence stays. A closed period is rejected, including an edit after lastPeriod. An edit or a log for a habit the caller does not own is not found, before that period is checked. Name, description, notes, and a comment are limited by Unicode code points, the same count PostgreSQL char_length uses, so one emoji counts as one.

Comment deletion requires initiator rank. A moderator has that same rank. Sunday rest is the existing Time-Zone check: Sunday in that zone refuses comment, deleteComment, and invoice with SUNDAY_REST before the amount check. A missing or invalid zone does not refuse. A comment id that is not a UUID is { error: 'Not found' } with status 404 on deleteComment and invoice, before the store is asked, and it is not an outage. Revision name is 1–80 code points and description is at most 2000, the same checks as the habit row. A table created before those checks receives them the next time the schema runs. The invoice uses the comment author's current Lightning address. Visitor-facing app copy does not say Lightning or sats.

Reused:

src/lib/sunday-rest.ts:10 isSundayRestHeader — Sunday in the Time-Zone header. Missing, blank, or invalid does not count as Sunday. Used for comment, deleteComment, and invoice only.
src/lib/config.ts:38 GIFT_INVOICE_MAX_MSAT — 10_000_000 sat ceiling, same constant as a forum gift.
src/lib/gift-invoice.ts:40 requestGiftInvoice — creates the BOLT11 invoice. This route does not pay it.
src/lib/nostr/rate-limit.ts:124 InvoiceRateLimiter — same 1/10s and 20/h policy. The habit route keeps its own instance, so a habit invoice does not spend the forum counter.
src/routes/messages.ts:3066 — forum gift response { pr, amountSats }.
src/routes/messages.ts:2944 — forum Too many payments.
src/routes/pos.ts:74 — Expected a JSON body with an integer "amountSats".
src/routes/messages.ts:142 AUTHOR_WALLET_CANNOT_RECEIVE — the sentence "The author's wallet cannot receive this Bitcoin payment". A forum gift uses it when the wallet cannot mint a zap (src/routes/messages.ts:3015 and src/routes/messages.ts:3044), both status 400. src/routes/messages.ts:2804 is a note with no author, not a missing address, and that branch returns the wallet sentence at src/routes/messages.ts:2824. A forum note with no Lightning address says "This message cannot be paid yet" at src/routes/messages.ts:2873. A habit comment has no Nostr event, so that sentence does not fit. src/routes/member-habits.ts:486 uses the wallet sentence when the comment author has no Lightning address, and the status stays 409 because 400 on this route is the amount error.
src/routes/members.ts:133 { error: 'Not found' } — a non-UUID id is missing, not a sentence of its own. deleteComment and invoice use that same response.
src/index.ts:131 contactStore passed from boot into createApp — src/index.ts:132 passes memberHabitStore the same way.
src/routes/messages.ts:2060 Invalid body — a JSON body that is not the shape that route accepts. src/routes/member-habits.ts:295 uses that sentence when the habit body is not one of the habit actions.
src/routes/pos.ts:94 Lightning Address could not be resolved — status 502 when that address does not yield an invoice. src/routes/member-habits.ts:502 uses that sentence when the habit invoice cannot be built. src/routes/me.ts:934 uses the same sentence at status 400 while saving an account address, which is a different job.
src/lib/daily-roster.ts:17 Invalid comment — the spend roster refuses a comment it will not store. src/routes/member-habits.ts:417 uses those words when a habit comment is empty or longer than 2000 code points. A habit comment is not a roster row.

Added:

src/routes/member-habits.ts:303 Invalid time zone — add stores an IANA zone and refuses a missing or invalid one. Sunday rest cannot do that job, because an invalid zone there means not Sunday.
src/routes/member-habits.ts:138 Invalid name — the habit title is empty or longer than 80 Unicode code points after trim. src/routes/me.ts:404 Name must be 1–80 characters rejects the account display name on POST /me/name. This route does not change that name, so the account sentence is a different job. src/routes/member-habits.ts:307 returns this sentence on add, and src/routes/member-habits.ts:330 returns it on edit.
src/routes/member-habits.ts:141 Invalid description — the public habit description is longer than 2000 code points. No existing sentence checks a habit description.
src/routes/member-habits.ts:144 Invalid notes — the private notes are longer than 2000 code points. No existing sentence checks habit notes.
src/routes/member-habits.ts:272 Habits are unavailable — the habit store failed. No existing sentence reports that.
src/routes/member-habits.ts:375 Invalid status — a log status is not achieved, partial, or missed. No existing sentence checks a habit log.
src/routes/member-habits.ts:383 Invalid period — the period is not a real day, or not a Monday when the habit is weekly. No existing sentence checks a habit period.
src/routes/member-habits.ts:339 Period is closed — an edit whose current period is after lastPeriod. The stored wording does not change. src/routes/member-habits.ts:399 is that same sentence when a log is no longer ratable.
src/routes/member-habits.ts:478 Cannot donate to yourself — the caller is paying their own habit comment. src/routes/conversations.ts:590 Cannot message yourself refuses opening a conversation with oneself. src/routes/conversations.ts:1198 uses that same sentence when a conversation invoice's counterpart is the caller, because that payment is a message in the thread. A habit comment is not a message and has no thread, so that sentence would tell the donor they failed to message themselves. The donation refusal is a different job.
src/routes/member-habits.ts:224 app.get — GET /habits. No existing route lists a member habit, its periods, or a comment on that habit.
src/routes/member-habits.ts:276 app.post — POST /habits. No existing route adds, edits, archives, logs, comments on, or invoices a member habit.

github-actions · 2026-10-05T11:08:16Z

dfx pr guard

EN:
A38 pass
Thanks for your contribution! This repository follows A38. A38 pass: author local-CI report not required because the author has write on this repository.

DE:
A38 bestanden
Danke für deinen Beitrag! In diesem Repository gilt A38. A38 pass: Autor-Local-CI-Report nicht erforderlich, weil der Autor Write auf diesem Repository hat.

Details

A38 standard: https://github.com/DFXswiss/agent/blob/59e31ebd11ab587897dc8e5b2a6f21e489f35f3d/docs/a38.md
Active policy: https://github.com/21gifts/api/blob/596fc9bb4170b14b3d6e1244c2e9e3d6ddcc74cc/.github/a38.json
Base: 596fc9bb4170b14b3d6e1244c2e9e3d6ddcc74cc; policy revision: 596fc9bb4170b14b3d6e1244c2e9e3d6ddcc74cc.
Save the active revision of .github/a38.json as /tmp/a38-policy.json before running.
Guard docs: https://github.com/DFXswiss/agent/blob/59e31ebd11ab587897dc8e5b2a6f21e489f35f3d/docs/a38-guard.md
Required jobs: Lint
Problems: none
For a workflow or policy change, another maintainer must approve this pull request on the current head. No special review text is required.
Run (outside the repo output paths): python -m agent_cli.a38 run --repo . --policy /tmp/a38-policy.json --base-sha 596fc9bb4170b14b3d6e1244c2e9e3d6ddcc74cc --output /tmp/a38-report.md --logs-dir /tmp/a38-logs --repository 21gifts/api
Publish: an author local-CI report is optional for this write-collaborator waiver; if posted, use the PR author's account and preserve the report block.

TaprootFreakAI · 2026-10-06T00:47:22Z

EN:
Ready after 1 review passes.
Any signed-in member can keep a daily or weekly habit, comment on it, and request a Bitcoin invoice that the API does not pay.

DE:
Bereit nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine tägliche oder wöchentliche Gewohnheit führen, sie kommentieren und eine Bitcoin-Rechnung anfragen, die die API nicht bezahlt.

Details

Head: a40fd6ddd67835ce99218795110d4a1e6c94e67d
Runs: conformity-a with logic-a. The second run may be omitted.
Lane conformity-a:
Provider: xAI
Model: grok-4.6
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-a:
Provider: xAI
Model: grok-4.6
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 1, defects 0.
Set aside: none.

{
  "schema": "a38-review/v2",
  "head": "a40fd6ddd67835ce99218795110d4a1e6c94e67d",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {"id": "conformity-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "grok-4.6", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."},
    {"id": "logic-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "grok-4.6", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for logical correctness."}
  ]
}

The pair read the diff against the base rules and the acceptance criteria. No defect remained. Coverage was not executed in the review lane. The open pull request checks on this head were already green.

github-actions · 2026-10-06T00:47:50Z

EN:
Required CI is green, the review completion is present, and no merge conflicts exist; this pull request is ready for review.

DE:
Die Required CI ist grün, der Review-Abschluss liegt vor und es gibt keine Merge-Konflikte; dieser Pull Request ist bereit zum Review.

Details

{
  "base": "316d4fb2b04008628458c62c8aacc91ed4fda47c",
  "head": "a40fd6ddd67835ce99218795110d4a1e6c94e67d",
  "phase": "applied",
  "pr": 399,
  "reasons": [],
  "repo": "21gifts/api",
  "state": "ready"
}

TaprootFreakAI · 2026-10-06T01:12:59Z

EN:
Ready after 1 review passes.
Any signed-in member can keep a daily or weekly habit, comment on it, and request a Bitcoin invoice that the API does not pay.

DE:
Bereit nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine tägliche oder wöchentliche Gewohnheit führen, sie kommentieren und eine Bitcoin-Rechnung anfragen, die die API nicht bezahlt.

Details

Head: a8441b3dbeba99f24004ff1b9a3f72503a62c467
Runs: conformity-a with logic-a. The second run may be omitted.
Lane conformity-a:
Provider: xAI
Model: grok-4.6
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-a:
Provider: xAI
Model: grok-4.6
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 1, defects 0.
Set aside: none.

{
  "schema": "a38-review/v2",
  "head": "a8441b3dbeba99f24004ff1b9a3f72503a62c467",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {"id": "conformity-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "grok-4.6", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."},
    {"id": "logic-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "grok-4.6", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for logical correctness."}
  ]
}

The pair read the diff against the base rules and the acceptance criteria, including the commit that writes each habit wording change as one statement. No defect remained. Coverage was not executed in the review lane. The open pull request checks on this head were already green.

github-actions · 2026-10-06T01:13:28Z

EN:
Required CI is green, the review completion is present, and no merge conflicts exist; this pull request is ready for review.

DE:
Die Required CI ist grün, der Review-Abschluss liegt vor und es gibt keine Merge-Konflikte; dieser Pull Request ist bereit zum Review.

Details

{
  "base": "316d4fb2b04008628458c62c8aacc91ed4fda47c",
  "head": "a8441b3dbeba99f24004ff1b9a3f72503a62c467",
  "phase": "applied",
  "pr": 399,
  "reasons": [],
  "repo": "21gifts/api",
  "state": "ready"
}

TaprootFreakAI · 2026-10-06T01:40:03Z

EN:
Ready after 1 review passes.
Any signed-in member can keep a daily or weekly habit, comment on it, and request a Bitcoin invoice that the API does not pay.

DE:
Bereit nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine tägliche oder wöchentliche Gewohnheit führen, sie kommentieren und eine Bitcoin-Rechnung anfragen, die die API nicht bezahlt.

Details

Head: 629229053bdd7cb3676dfaba4629187c85d4f3d5
Runs: conformity-a with logic-a. The second run may be omitted.
Lane conformity-a:
Provider: xAI
Model: grok-4.6
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-a:
Provider: xAI
Model: grok-4.6
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 1, defects 0.
Set aside: none.

{
  "schema": "a38-review/v2",
  "head": "629229053bdd7cb3676dfaba4629187c85d4f3d5",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {"id": "conformity-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "grok-4.6", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."},
    {"id": "logic-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "grok-4.6", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for logical correctness."}
  ]
}

The pair read the full diff against the base rules and the acceptance criteria. Editing a habit's wording now checks the owner in the same statement as the revision, and a missing or unowned habit writes nothing. Archive and log still read the row first, because that read decides missing or closed before a write that does not insert a revision. No defect remained.

github-actions · 2026-10-06T01:40:28Z

EN:
Required CI is green, the review completion is present, and no merge conflicts exist; this pull request is ready for review.

DE:
Die Required CI ist grün, der Review-Abschluss liegt vor und es gibt keine Merge-Konflikte; dieser Pull Request ist bereit zum Review.

Details

{
  "base": "316d4fb2b04008628458c62c8aacc91ed4fda47c",
  "head": "629229053bdd7cb3676dfaba4629187c85d4f3d5",
  "phase": "applied",
  "pr": 399,
  "reasons": [],
  "repo": "21gifts/api",
  "state": "ready"
}

TaprootFreakAI · 2026-10-06T02:30:24Z

EN:
Ready after 1 review passes.
Any signed-in member can keep a habit, comment on it, and request a Bitcoin invoice that this API does not pay.

DE:
Bereit nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine Gewohnheit führen, kommentieren und eine Bitcoin-Rechnung anfordern, die diese API nicht bezahlt.

Details

Head: cf05ea3e7813f16cc88ae0b735a2e407305fc975
Runs: conformity-a with logic-a. The second run may be omitted.
Lane conformity-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 1, defects 0.
Set aside: none.

Comment deletion uses the existing rank check only. Both lanes reported no defects on this head.

{
  "schema": "a38-review/v2",
  "head": "cf05ea3e7813f16cc88ae0b735a2e407305fc975",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {"id": "conformity-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "Grok", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."},
    {"id": "logic-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "Grok", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for logical correctness."}
  ]
}

github-actions · 2026-10-06T02:30:52Z

EN:
Required CI is green, the review completion is present, and no merge conflicts exist; this pull request is ready for review.

DE:
Die Required CI ist grün, der Review-Abschluss liegt vor und es gibt keine Merge-Konflikte; dieser Pull Request ist bereit zum Review.

Details

{
  "base": "316d4fb2b04008628458c62c8aacc91ed4fda47c",
  "head": "cf05ea3e7813f16cc88ae0b735a2e407305fc975",
  "phase": "applied",
  "pr": 399,
  "reasons": [],
  "repo": "21gifts/api",
  "state": "ready"
}

TaprootFreakAI · 2026-10-06T03:31:00Z

EN:
Ready after 2 review passes.
Any signed-in member can keep a habit, comment on it, and request a Bitcoin invoice that this API does not pay.

DE:
Bereit nach 2 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine Gewohnheit führen, kommentieren und eine Bitcoin-Rechnung anfordern, die diese API nicht bezahlt.

Details

Head: 5969f74ea1f5027face0b8d9f16c184566f8cb7f
Runs: conformity-a with logic-a. The second run may be omitted.
Lane conformity-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 2, defects 0.
Set aside: none.

The first pass on this head found one wrong citation: the wallet sentence was attributed to a forum note with no author. The pull request text now cites the wallet sentence, the zap refusal, and the habit route's own 409. Name, description, notes, and comments are limited by Unicode code points, the same count as PostgreSQL char_length. Both lanes then reported no defects.

{
  "schema": "a38-review/v2",
  "head": "5969f74ea1f5027face0b8d9f16c184566f8cb7f",
  "passes": 2,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {"id": "conformity-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "Grok", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."},
    {"id": "logic-a", "result": "pass", "status": "complete", "provider": "xAI", "model": "Grok", "model_number": "grok-4.6", "prompt": "Review the complete PR diff for logical correctness."}
  ]
}

github-actions · 2026-10-06T03:31:34Z

EN:
Required CI is green, the review completion is present, and no merge conflicts exist; this pull request is ready for review.

DE:
Die Required CI ist grün, der Review-Abschluss liegt vor und es gibt keine Merge-Konflikte; dieser Pull Request ist bereit zum Review.

Details

{
  "base": "316d4fb2b04008628458c62c8aacc91ed4fda47c",
  "head": "5969f74ea1f5027face0b8d9f16c184566f8cb7f",
  "phase": "applied",
  "pr": 399,
  "reasons": [],
  "repo": "21gifts/api",
  "state": "ready"
}

TaprootFreakAI · 2026-10-06T05:27:48Z

EN:
Ready after 1 review passes.
Any signed-in member can keep a daily or weekly habit, comment on it, and request a Bitcoin invoice that the API does not pay.

DE:
Bereit nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine tägliche oder wöchentliche Gewohnheit führen, sie kommentieren und eine Bitcoin-Rechnung anfragen, die die API nicht bezahlt.

Details

Head: f18ae18db28bc1222536b1e1431d1fd4c998260b
Runs: conformity-a with logic-a. The second run may be omitted.

Lane conformity-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Read CONTRIBUTING.md and REVIEW.md at the base revision. Review this pull request against those files and against the linked issue. Do not change any files.

Lane logic-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Read CONTRIBUTING.md and REVIEW.md at the base revision. Review this pull request against those files and against the linked issue. Do not change any files.

Final result: passes 1, defects 0.
Set aside: none

{
  "schema": "a38-review/v2",
  "head": "f18ae18db28bc1222536b1e1431d1fd4c998260b",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {
      "id": "conformity-a",
      "result": "pass",
      "status": "complete",
      "provider": "xAI",
      "model": "Grok",
      "model_number": "grok-4.6",
      "prompt": "Read CONTRIBUTING.md and REVIEW.md at the base revision. Review this pull request against those files and against the linked issue. Do not change any files."
    },
    {
      "id": "logic-a",
      "result": "pass",
      "status": "complete",
      "provider": "xAI",
      "model": "Grok",
      "model_number": "grok-4.6",
      "prompt": "Read CONTRIBUTING.md and REVIEW.md at the base revision. Review this pull request against those files and against the linked issue. Do not change any files."
    }
  ]
}

github-actions · 2026-10-06T05:28:22Z

EN:
Required CI is green, the review completion is present, and no merge conflicts exist; this pull request is ready for review.

DE:
Die Required CI ist grün, der Review-Abschluss liegt vor und es gibt keine Merge-Konflikte; dieser Pull Request ist bereit zum Review.

Details

{
  "base": "316d4fb2b04008628458c62c8aacc91ed4fda47c",
  "head": "f18ae18db28bc1222536b1e1431d1fd4c998260b",
  "phase": "applied",
  "pr": 399,
  "reasons": [],
  "repo": "21gifts/api",
  "state": "ready"
}

TaprootFreakAI · 2026-10-06T06:34:40Z

EN:
Ready after 1 review passes.
Any signed-in member can keep a daily or weekly habit, comment on it, and request a Bitcoin invoice that the API does not pay.

DE:
Bereit nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine tägliche oder wöchentliche Gewohnheit führen, sie kommentieren und eine Bitcoin-Rechnung anfragen, die die API nicht bezahlt.

Details

Head: f9878c47ddedc0537aac0b7dd6db7ee50af033a5
Runs: conformity-a with logic-a. The second run may be omitted.

Lane conformity-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Read CONTRIBUTING.md and REVIEW.md at the base revision. Review this pull request against those files and against the linked issue. Do not change any files.

Lane logic-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Read CONTRIBUTING.md and REVIEW.md at the base revision. Review this pull request against those files and against the linked issue. Do not change any files.

Final result: passes 1, defects 0.
Set aside: none

{
  "schema": "a38-review/v2",
  "head": "f9878c47ddedc0537aac0b7dd6db7ee50af033a5",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {
      "id": "conformity-a",
      "result": "pass",
      "status": "complete",
      "provider": "xAI",
      "model": "Grok",
      "model_number": "grok-4.6",
      "prompt": "Read CONTRIBUTING.md and REVIEW.md at the base revision. Review this pull request against those files and against the linked issue. Do not change any files."
    },
    {
      "id": "logic-a",
      "result": "pass",
      "status": "complete",
      "provider": "xAI",
      "model": "Grok",
      "model_number": "grok-4.6",
      "prompt": "Read CONTRIBUTING.md and REVIEW.md at the base revision. Review this pull request against those files and against the linked issue. Do not change any files."
    }
  ]
}

github-actions · 2026-10-06T06:35:20Z

EN:
Required CI is green, the review completion is present, and no merge conflicts exist; this pull request is ready for review.

DE:
Die Required CI ist grün, der Review-Abschluss liegt vor und es gibt keine Merge-Konflikte; dieser Pull Request ist bereit zum Review.

Details

{
  "base": "316d4fb2b04008628458c62c8aacc91ed4fda47c",
  "head": "f9878c47ddedc0537aac0b7dd6db7ee50af033a5",
  "phase": "applied",
  "pr": 399,
  "reasons": [],
  "repo": "21gifts/api",
  "state": "ready"
}

… store a wallet.

…error. A habit invoice that omits the amount, or sends one that is not a number, returns the same visible error as a gift. A failed mint names the Lightning Address, and the new tables reference the account and the habit.

…llet error.

The owner predicate sits in the same statement as the wording update and the period revision. A missing or unowned habit writes nothing.

The wording update no longer reads the row first, so the owner mismatch on the remaining read has to be reached from archive and log.

A comment id that is not a UUID is Not found before the store, and a well-formed id that is missing is the same response. Revision name and description get the same length checks as the habit row, including a table created before those checks.

Creating the table twice never reached the follow-up constraint, so a revision table from before those checks could ship without them.

A habit gift returns the payment request only when it decodes to exactly the requested millisatoshis, the same check the existing pay invoice already uses.

…habit.

TaprootFreakAI · 2026-10-07T17:31:11Z

EN:
Ready after 1 review passes.
Any signed-in member can keep a daily or weekly habit, comment on it, and request a Bitcoin invoice that the API does not pay.

DE:
Bereit nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine tägliche oder wöchentliche Gewohnheit führen, sie kommentieren und eine Bitcoin-Rechnung anfragen, die die API nicht bezahlt.

Details

Head: b1d68535777393483351c11d66dd4e9b085a7f3a
Runs: conformity-a with logic-a. The second run may be omitted.
Lane conformity-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 1, defects 0.
Set aside: none.

{
  "schema": "a38-review/v2",
  "head": "b1d68535777393483351c11d66dd4e9b085a7f3a",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {
      "id": "conformity-a",
      "result": "pass",
      "status": "complete",
      "provider": "xAI",
      "model": "Grok",
      "model_number": "grok-4.6",
      "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."
    },
    {
      "id": "logic-a",
      "result": "pass",
      "status": "complete",
      "provider": "xAI",
      "model": "Grok",
      "model_number": "grok-4.6",
      "prompt": "Review the complete PR diff for logical correctness."
    }
  ]
}

This pass reports no defects.

TaprootFreakAI · 2026-10-07T17:31:12Z

EN:
Ready after 1 review passes.
Any signed-in member can keep a daily or weekly habit, comment on it, and request a Bitcoin invoice that the API does not pay.

DE:
Bereit nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine tägliche oder wöchentliche Gewohnheit führen, sie kommentieren und eine Bitcoin-Rechnung anfragen, die die API nicht bezahlt.

Details

Head: b1d68535777393483351c11d66dd4e9b085a7f3a
Runs: conformity-b with logic-b. The second run may be omitted.
Lane conformity-b:
Provider: OpenAI
Model: GPT-5.6 Sol
Model number: gpt-5.6-sol
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-b:
Provider: OpenAI
Model: GPT-5.6 Sol
Model number: gpt-5.6-sol
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 1, defects 0.
Set aside: none.

{
  "schema": "a38-review/v2",
  "head": "b1d68535777393483351c11d66dd4e9b085a7f3a",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {
      "id": "conformity-b",
      "result": "pass",
      "status": "complete",
      "provider": "OpenAI",
      "model": "GPT-5.6 Sol",
      "model_number": "gpt-5.6-sol",
      "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."
    },
    {
      "id": "logic-b",
      "result": "pass",
      "status": "complete",
      "provider": "OpenAI",
      "model": "GPT-5.6 Sol",
      "model_number": "gpt-5.6-sol",
      "prompt": "Review the complete PR diff for logical correctness."
    }
  ]
}

This pass reports no defects.

TaprootFreakAI · 2026-10-07T17:31:13Z

A38 recheck

TaprootFreakAI · 2026-10-07T17:36:48Z

EN:
First review
Ready after 1 review passes.
Any signed-in member can keep a daily or weekly habit, comment on it, and request a Bitcoin invoice that the API does not pay.

DE:
Erster Review
Bereit nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine tägliche oder wöchentliche Gewohnheit führen, sie kommentieren und eine Bitcoin-Rechnung anfragen, die die API nicht bezahlt.

Details

Head: b1d68535777393483351c11d66dd4e9b085a7f3a
Runs: conformity-a with logic-a. The second run may be omitted.
Lane conformity-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-a:
Provider: xAI
Model: Grok
Model number: grok-4.6
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 1, defects 0.
Set aside: none.

{
  "schema": "a38-review/v2",
  "head": "b1d68535777393483351c11d66dd4e9b085a7f3a",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {
      "id": "conformity-a",
      "result": "pass",
      "status": "complete",
      "provider": "xAI",
      "model": "Grok",
      "model_number": "grok-4.6",
      "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."
    },
    {
      "id": "logic-a",
      "result": "pass",
      "status": "complete",
      "provider": "xAI",
      "model": "Grok",
      "model_number": "grok-4.6",
      "prompt": "Review the complete PR diff for logical correctness."
    }
  ]
}

This pass reports no defects.

TaprootFreakAI · 2026-10-07T17:36:49Z

EN:
Second review
Second review after 1 review passes.
Any signed-in member can keep a daily or weekly habit, comment on it, and request a Bitcoin invoice that the API does not pay.

DE:
Zweiter Review
Zweiter Review nach 1 Review-Durchläufen.
Jedes angemeldete Mitglied kann eine tägliche oder wöchentliche Gewohnheit führen, sie kommentieren und eine Bitcoin-Rechnung anfragen, die die API nicht bezahlt.

Details

Head: b1d68535777393483351c11d66dd4e9b085a7f3a
Runs: conformity-b with logic-b. The second run may be omitted.
Lane conformity-b:
Provider: OpenAI
Model: GPT-5.6 Sol
Model number: gpt-5.6-sol
Result: pass
Prompt:

Review the complete PR diff for conformity with CONTRIBUTING.md.

Lane logic-b:
Provider: OpenAI
Model: GPT-5.6 Sol
Model number: gpt-5.6-sol
Result: pass
Prompt:

Review the complete PR diff for logical correctness.

Final result: passes 1, defects 0.
Set aside: none.

{
  "schema": "a38-review/v2",
  "head": "b1d68535777393483351c11d66dd4e9b085a7f3a",
  "passes": 1,
  "defects": 0,
  "set_aside": "none",
  "lanes": [
    {
      "id": "conformity-b",
      "result": "pass",
      "status": "complete",
      "provider": "OpenAI",
      "model": "GPT-5.6 Sol",
      "model_number": "gpt-5.6-sol",
      "prompt": "Review the complete PR diff for conformity with CONTRIBUTING.md."
    },
    {
      "id": "logic-b",
      "result": "pass",
      "status": "complete",
      "provider": "OpenAI",
      "model": "GPT-5.6 Sol",
      "model_number": "gpt-5.6-sol",
      "prompt": "Review the complete PR diff for logical correctness."
    }
  ]
}

This pass reports no defects.

TaprootFreakAI · 2026-10-07T17:36:51Z

A38 recheck

github-actions · 2026-10-07T17:37:20Z

EN:
Ready for review
Required CI is green, the review completion is present, and no merge conflicts exist; this pull request is ready for review.

DE:
Bereit zum Review
Die Required CI ist grün, der Review-Abschluss liegt vor und es gibt keine Merge-Konflikte; dieser Pull Request ist bereit zum Review.

Details

{
  "base": "596fc9bb4170b14b3d6e1244c2e9e3d6ddcc74cc",
  "head": "b1d68535777393483351c11d66dd4e9b085a7f3a",
  "phase": "applied",
  "pr": 399,
  "reasons": [],
  "repo": "21gifts/api",
  "state": "ready"
}

TaprootFreakAI changed the title ~~01a10b01 - Add member habits with comment windows and Bitcoin invoices~~ 01a10b01 - Add member habits with comments and Bitcoin invoices Oct 5, 2026

TaprootFreakAI force-pushed the feat/member-habits branch from 997dc28 to 90e0704 Compare October 5, 2026 23:13

github-actions Bot marked this pull request as ready for review October 6, 2026 00:47

TaprootFreakAI marked this pull request as draft October 6, 2026 00:58

github-actions Bot marked this pull request as ready for review October 6, 2026 01:13

TaprootFreakAI marked this pull request as draft October 6, 2026 01:20

github-actions Bot marked this pull request as ready for review October 6, 2026 01:40

TaprootFreakAI marked this pull request as draft October 6, 2026 01:47

github-actions Bot marked this pull request as ready for review October 6, 2026 02:30

TaprootFreakAI marked this pull request as draft October 6, 2026 02:50

github-actions Bot marked this pull request as ready for review October 6, 2026 03:31

TaprootFreakAI marked this pull request as draft October 6, 2026 03:59

github-actions Bot marked this pull request as ready for review October 6, 2026 05:28

TaprootFreakAI marked this pull request as draft October 6, 2026 05:47

github-actions Bot marked this pull request as ready for review October 6, 2026 06:35

TaprootFreakAI added 12 commits October 7, 2026 17:37

Document the habit boot path and cover the address port that does not…

19ea926

… store a wallet.

01a10b01 - Pass the SQL habit store into the process and reuse the wa…

9318df6

…llet error.

01a10b01 - Document the habit list response and the store failure.

697b49b

01a10b01 - Write each habit wording change as one statement.

45a6763

01a10b01 - Check habit ownership inside the wording update.

f273569

The owner predicate sits in the same statement as the wording update and the period revision. A missing or unowned habit writes nothing.

01a10b01 - Cover an unowned habit on archive and log.

641ff8b

The wording update no longer reads the row first, so the owner mismatch on the remaining read has to be reached from archive and log.

01a10b01 - Check comment deletion with roleAtLeast only.

784bc38

01a10b01 - Count habit text in Unicode code points.

ff012b5

01a10b01 - Prove a reused habit revision table gains its length checks.

9b85d79

Creating the table twice never reached the follow-up constraint, so a revision table from before those checks could ship without them.

01a10b01 - Reject a habit invoice that is not the requested amount.

2b783d3

A habit gift returns the payment request only when it decodes to exactly the requested millisatoshis, the same check the existing pay invoice already uses.

TaprootFreakAI force-pushed the feat/member-habits branch from f9878c4 to 2b783d3 Compare October 7, 2026 15:37

TaprootFreakAI added 6 commits October 7, 2026 17:42

01a10b01 - Keep the route table separate from the auth note.

ae3820d

01a10b01 - Refuse another member's habit log before the period check.

b795a59

01a10b01 - Cover a habit log the store no longer has.

81192fb

01a10b01 - Reject another member's habit log before the period shape.

67bbacb

01a10b01 - Refuse a habit edit after the archived period.

6f70115

01a10b01 - Return not found before a closed period on someone else's …

b1d6853

…habit.

github-actions Bot marked this pull request as ready for review October 7, 2026 17:37

TaprootFreak merged commit 106a8f7 into develop Oct 7, 2026
5 checks passed

TaprootFreakAI mentioned this pull request Oct 7, 2026

Add retrospective Habit-Tracker with comment windows and Bitcoin donations #373

Closed

Daniel-DFX mentioned this pull request Oct 7, 2026

5f2db80c - Preview: staging rebased onto develop #426

Draft

Conversation

TaprootFreakAI commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaprootFreakAI commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaprootFreakAI commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaprootFreakAI commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaprootFreakAI commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaprootFreakAI commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaprootFreakAI commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaprootFreakAI commented Oct 6, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TaprootFreakAI commented Oct 7, 2026

Uh oh!

TaprootFreakAI commented Oct 7, 2026

Uh oh!

TaprootFreakAI commented Oct 7, 2026

Uh oh!

TaprootFreakAI commented Oct 7, 2026

Uh oh!

TaprootFreakAI commented Oct 7, 2026

Uh oh!

TaprootFreakAI commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TaprootFreakAI commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 5, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading

github-actions Bot commented Oct 6, 2026 •

edited

Loading

github-actions Bot commented Oct 7, 2026 •

edited

Loading