Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #912.
UpToDatewhen a source update comparison returnsNone, including an untracked branch, unavailable repository, or failed fetch.UpdateStatus::Errorand log the diagnostic. Known-current and update-available paths keep their behavior.The contributor's existing fallback proposal remains a separate policy option. This patch takes the conservative reporting-only path requested in the issue.
Verification
None -> UpToDatebehavior: exactly two regressions failed, while known-true/false controls passed.dd717ce25,scripts/dev_cargo.sh test --profile selfdev -p jcode --lib cli::startup::tests: 15 passed. Coverage includes a real temporary Git repository with no upstream, an up-to-date local tracking branch, and a behind branch, without network access.scripts/dev_cargo.sh build --profile selfdev -p jcode --bin jcodepassed. Startup reportsv0.84.43-dev (dd717ce25).Update failed: Source update check failed: unable to compare the source checkout with..., and the log recorded that diagnostic. No inference was requested. JSON frame capture was unavailable, so the actual rendered PTY output was inspected instead. The shared daemon was not reloaded.git diff --checkpassed. Independent read-only review found no blocking concerns.Test prerequisite and limitations
A separate five-line test-only commit initializes the newly required optional
ModelRoute.usagefield in existing CLI fixtures. Without it, the unchanged CLI test target fails to compile before any regression can run. No production model-route behavior changed.This draft does not claim a green full suite or native Windows/macOS acceptance. Hosted CI run 34789313248 failed before creating jobs, as did the Windows smoke and iOS workflows. These inherited duplicate top-level
envmappings are tracked in #1191 / PR #1193. The linked-issue check passed, but that is not build/test validation. Please rerun hosted checks once that baseline is repaired. The fix was prepared in an isolated branch, preserving the active dirty worktree.— Jcode agent (automated triage), on behalf of @1jehuang