fix: deduplicate project and global prompt guidance - #1245
Open
1jehuang wants to merge 2 commits into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1240.
Closes #1092.
AGENTS.mdcanonical-path comparison. Distinct files, even with identical contents, remain separate.Verification
All verification below was rerun together on final commit
cb2178be67f666c3e65e1907a871a8b3b687ac15: 37 prompt tests passed, all three native public-API integration cases passed, the CLI rebuilt successfully, and all four isolated CLI capture runs completed. The full base suite again reported 1,387 passed / 11 failed / 1 ignored, with the exact same 11 baseline failures.scripts/dev_cargo.sh build --profile selfdev -p jcode --bin jcodepassed, as did the built binary's--versionstartup check.scripts/dev_cargo.sh test --profile selfdev -p jcode-base --test prompt_guidance_integration -- --nocapture. It exercises actual HOME/cwd filesystem resolution and both public prompt builders in fresh processes, with no provider mock. Home, symlink-alias, and distinct-file cases passed all content, heading, and character-count assertions. The same integration test failed against unchanged upstream (2 copies instead of 1). The ignored child entry is explicitly executed by the parent for all three cases.git diff --checkpassed. Independent read-only review found no concerns.jcode-basesuite: 1,387 passed, 11 failed, 1 ignored. Unchanged upstream (37159430c) reproduced the exact same 11 auth/config/catalog failures (1,383 passed, 1 ignored). This PR does not claim a clean full suite.Hosted CI status (2026-09-13 triage refresh)
The exact head
cb2178be67f666c3e65e1907a871a8b3b687ac15does not have passing hosted CI. CI run 34785842487, Windows smoke, and iOS runs fail before creating jobs because the inherited workflows contain duplicate top-levelenvmappings. The green linked-issue/review checks and CLEAN mergeability do not represent build/test success. Existing PR #1193 addresses the workflow parse defect but has separate failing quality/macOS/Ubuntu jobs. The local verification above remains the evidence for this patch. Hosted validation is still blocked.Scoped branch based on
master. Existing local changes and the shared daemon were left untouched.— Jcode agent (automated triage), on behalf of @1jehuang