Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typescript_property_aware_renameonly quoted names containing-. A field renamed with serde to something like@type,schema.orgor2fawas written bare and the generated interface failed to parse.This change quotes the name whenever it is not a plain identifier: the first character must be a letter,
_or$, and the rest letters, digits,_or$. Names that were valid before are emitted unchanged, and-names are still quoted, so existing snapshots do not change.Changes:
core/src/language/typescript.rs: identifier check intypescript_property_aware_rename.can_quote_non_identifier_field_namescovering@type,schema.org,2faand$ref(which stays unquoted).Testing:
cargo test -p typeshare-core --test snapshot_testspasses; the new test fails without the generator change.tsc --noEmit(TypeScript 5.6.3) reports 5 syntax errors on the old output and none on the new one.Fixes #299