Skip to content

[FEATURE] Ajouter une sécurité aux routes de déploiement (PIX-23248). - #711

Merged
Libouk merged 1 commit into
mainfrom
pix-23248-add-security-to-deploy-endpoints
Oct 7, 2026
Merged

Libouk merged 1 commit into
mainfrom
pix-23248-add-security-to-deploy-endpoints

Conversation

@Libouk

@Libouk Libouk commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

📚 Problème

Suite à l'audit de sécurité des routes Pix Bot, il a été remarqué que deux routes ne sont pas sécurisées : les routes /build/scalingo/deploy-endpoint et /build/scalingo/review-app-deploy-endpoint.

🎒 Proposition

Ajouter un token sur les notifiers Scalingo des routes /deploy-endpoint et /review-app-deploy-endpoint, vérifier dans scalingo.js que le token fourni correspond à celui renseigné dans la variable d'env SCALINGO_NOTIFIER_TOKEN

📐 Pour tester

Le déploiement doit fonctionner.

@Libouk Libouk self-assigned this Sep 30, 2026
@Libouk Libouk added the team-captains This is your captain speaking label Sep 30, 2026
@pix-bot-github

pix-bot-github commented Sep 30, 2026 •

Copy link
Copy Markdown

Choisir les applications à déployer :

@Libouk
Libouk force-pushed the pix-23248-add-security-to-deploy-endpoints branch 4 times, most recently from 6db2327 to 22c3ad9 Compare October 6, 2026 08:52
@Libouk
Libouk force-pushed the pix-23248-add-security-to-deploy-endpoints branch from 22c3ad9 to c8aa29c Compare October 7, 2026 15:28
@Libouk
Libouk force-pushed the pix-23248-add-security-to-deploy-endpoints branch from c8aa29c to 27a8bc6 Compare October 7, 2026 15:36
@Libouk
Libouk merged commit 7f68ccb into main Oct 7, 2026
4 checks passed
@Libouk
Libouk deleted the pix-23248-add-security-to-deploy-endpoints branch October 7, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-captains This is your captain speaking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants