Repository navigation
[FEATURE] Ajouter une sécurité aux routes de déploiement (PIX-23248). - #711
Merged
Merged
Conversation
|
Choisir les applications à déployer : |
Libouk
force-pushed
the
pix-23248-add-security-to-deploy-endpoints
branch
4 times, most recently
from
October 6, 2026 08:52
6db2327 to
22c3ad9
Compare
Libouk
force-pushed
the
pix-23248-add-security-to-deploy-endpoints
branch
from
October 7, 2026 15:28
22c3ad9 to
c8aa29c
Compare
Libouk
force-pushed
the
pix-23248-add-security-to-deploy-endpoints
branch
from
October 7, 2026 15:36
c8aa29c to
27a8bc6
Compare
hakkanicko
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Problème
Suite à l'audit de sécurité des routes Pix Bot, il a été remarqué que deux routes ne sont pas sécurisées : les routes
/build/scalingo/deploy-endpointet/build/scalingo/review-app-deploy-endpoint.🎒 Proposition
Ajouter un token sur les notifiers Scalingo des routes /deploy-endpoint et /review-app-deploy-endpoint, vérifier dans scalingo.js que le token fourni correspond à celui renseigné dans la variable d'env SCALINGO_NOTIFIER_TOKEN
📐 Pour tester
Le déploiement doit fonctionner.