Repository navigation
Add reusable device denoising and MOSS SoundEffect fusions - #1251
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOSS SoundEffect now uses a shared device denoiser runtime with session-owned graphs and buffers. Graph-scoped normalization/affine, bias/activation and gated-residual fusions reduce warmed denoiser time by 7.8% on CUDA and 9.1% on Vulkan compared with the same runtime using ordinary kernels.
Changes
DeviceDenoiserRuntimeandDeviceFlowSamplerRuntimefor cached execution and device-resident CFG/Euler sampling. Each denoiser runtime owns one multi-graphPreparedGraph, which manages execution plans and shared scratch.AdaptiveLayerNormModulewith prepared modulation parameters and LayerNorm-affine modulation, reusing the existing normalization and tensor modules.moss_soundeffect.fused_epilogues=falseto disable them while retaining the device runtime.Performance
RTX 5090, fully GPU-resident BF16 package, eight threads, 50 Euler steps, CFG 4, sigma shift 5 and a full 30-second denoising canvas. Each configuration used one unrelated warmup followed by three measured 10-second outputs, covering English rain/thunder and Chinese forest/birds prompts with fixed seeds and a repeated request. Denoiser time excludes text encoding and VAE decoding; RTF covers the complete request. Peak VRAM is the observed process peak during warmed requests.
Vulkan's main-to-PR gain also includes native BF16 projection handling. The fusions-off/default comparison isolates the three pointwise fusions.
Validation