fix(standards): reject delay-only multisig procedure policies - #3781
Merged
Conversation
partylikeits1983
approved these changes
Sep 2, 2026
partylikeits1983
left a comment
partylikeits1983
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
non blocking: Question, when are we planning to add delayed / timelocked execution path for the smart multisig?
Collaborator
Author
|
@PhilippGackstatter I have a PR for the |
zeapoz
approved these changes
Sep 3, 2026
Comment on lines
+108
to
+109
| #! - delayed_threshold is non-zero while immediate_threshold is zero. | ||
| #! - note_restrictions is non-zero while immediate_threshold is zero. |
Collaborator
There was a problem hiding this comment.
Suggested change
| #! - delayed_threshold is non-zero while immediate_threshold is zero. | |
| #! - note_restrictions is non-zero while immediate_threshold is zero. | |
| #! - delayed_threshold or note_restrictions is non-zero while immediate_threshold is zero. |
nit: We could merge these to reduce redundancy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set_procedure_policy.ProcedurePolicyExecutionMode::DelayOnlyandProcedurePolicy::with_delay_thresholdso a delay-only policy cannot be included into an account's initial storage.AuthMultisigSmart::set_procedure_policy_root(), mirroringAuthMultisig::set_procedure_threshold_root().set_procedure_policyitself.Closes #3780.