Skip to content

feat(objects): add TransactionInputs protobuf message - #3776

Queued
kkovaacs wants to merge 71 commits into
nextfrom
krisztian/protobuf-transaction-inputs
Queued

feat(objects): add TransactionInputs protobuf message#3776
kkovaacs wants to merge 71 commits into
nextfrom
krisztian/protobuf-transaction-inputs

Conversation

@kkovaacs

@kkovaacs kkovaacs commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a canonical, no_std-compatible Protobuf representation for TransactionInputs, enabling structured exchange of transaction execution inputs.

Changes

  • Adds a versioned V1 message covering all nine TransactionInputs fields.
  • Adds structured messages for partial accounts, protocol configuration, transaction arguments, advice inputs, and input notes.
  • Adds validated conversions that reject malformed or duplicate data while producing canonical encodings.

Existing protocol commitments, native serialization, and the canonical MastForest representation remain unchanged.

kkovaacs added 30 commits August 31, 2026 08:29
@kkovaacs
feat: add miden-objects crate with canonical Protobuf encodings
e6a3656
@kkovaacs
refactor(proto): reshuffle protobuf files
bcc857e
@kkovaacs
fix: add ExecutionProof wrapper
6eb02c1
@kkovaacs
fix: add MastForest wrapper
89597d2
@kkovaacs
fix: cargo shear
f93a28b
@kkovaacs
fix: extract generic PublicKey
334db64
@kkovaacs
fix: extract generic Signature
9a76aac
@kkovaacs
fix: remove redundant checks from conversion code
0f30528
@kkovaacs
fix: fix conversion compile errors after rebase
bbfde6a
@kkovaacs
chore: update CHANGELOG
e90344c
@kkovaacs
fix: fix compile errors after rebase
7cb15d6
@kkovaacs
chore: allow duplicate protobuf build dependencies
ba87bf7
@kkovaacs
chore: remove schema tests
a7a01c0
@kkovaacs
fix(objects): adapt conversions to validated constructors
60c3515
@kkovaacs
refactor(objects): consolidate protobuf primitive types
0a6aec4
@kkovaacs
test(objects): cover missing protobuf block numbers
2273495
@kkovaacs
refactor(objects): align protobuf messages with domain types
b88be87
@kkovaacs
test(objects): cover block body conversion validation
f2eaab3
@kkovaacs
fix(objects): make account conversions lossless
907ca99
@kkovaacs
test(objects): cover invalid account nonce conversion
9cba279
@kkovaacs
perf(account): expose ordered storage patch iteration
6a28c5e
@kkovaacs
test(account): make storage patch order expectation explicit
78b08d1
@kkovaacs
fix(objects): address protobuf conversion clippy warnings
afd5ec5
@kkovaacs
refactor(objects): align account witness protobuf with domain type
e366c4d
@kkovaacs
test(objects): decouple account witness error assertion
5abbf2c
@kkovaacs
test(objects): remove redundant account witness fixture update
a8e9704
@kkovaacs
fix(objects): adapt block protobuf after rebase
c92d851
@kkovaacs
feat(objects): version account header protobuf
120ad35
@kkovaacs
feat(objects): version note metadata protobuf
d67c199
@kkovaacs
feat(objects): version block header protobuf
ead7d63
partylikeits1983
partylikeits1983 approved these changes Sep 3, 2026
View reviewed changes

@partylikeits1983 partylikeits1983 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kkovaacs
kkovaacs force-pushed the krisztian/protobuf-transaction-inputs branch from 6727fcb to dbe53b5 Compare September 3, 2026 10:13
@kkovaacs
kkovaacs force-pushed the krisztian/protobuf-transaction-inputs branch from dbe53b5 to bf5d468 Compare September 3, 2026 10:47
zeapoz
zeapoz approved these changes Sep 3, 2026
View reviewed changes

@zeapoz zeapoz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kkovaacs and others added 17 commits September 3, 2026 13:41
@kkovaacs
fix(objects): keep note type enum consistent with upstream type
78985ea
@kkovaacs
feat(protocol): expose transaction input protobuf parts
d347a42
@kkovaacs
feat(objects): add account config protobufs
b20656b
@kkovaacs
feat(objects): add transaction args protobufs
b97de25
@kkovaacs
feat(objects): add transaction inputs protobuf
92398ff
@kkovaacs
fix(protocol): satisfy transaction input lint
7768cc6
@kkovaacs
docs: add transaction inputs protobuf changelog
4b63010
@claude @kkovaacs
refactor(objects): clean up protobuf conversions
08e8ff7
@claude @kkovaacs
test(objects): clean up protobuf conversion tests
588cd3d
@claude @kkovaacs
docs: correct transaction inputs changelog
4d15617
@kkovaacs
fix: remove seen_ids in PartialVault::try_from_parts()
0d1a2bb
@kkovaacs
fix: invalid felt test
6937861
@kkovaacs
fix: use assert_matches! in tests
5e7b5ef
@kkovaacs
fix: clippy
907ba15
@kkovaacs
Revert "fix: remove seen_ids in PartialVault::try_from_parts()"
308696c 
This reverts commit d934eb9.
@kkovaacs
fix(objects): update protobuf conversions for dependency changes
fdb6a88
@kkovaacs
fix: VM upgrade compilation fixes
b4dcecb
@kkovaacs
kkovaacs force-pushed the krisztian/protobuf-transaction-inputs branch from bf5d468 to b4dcecb Compare September 3, 2026 11:44
@kkovaacs
kkovaacs added this pull request to the merge queue Sep 3, 2026
Any commits made after this event will not be merged.
Base automatically changed from krisztian/protobuf to next September 3, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bobbinth bobbinth bobbinth approved these changes
@Mirko-von-Leipzig Mirko-von-Leipzig Mirko-von-Leipzig approved these changes
@partylikeits1983 partylikeits1983 partylikeits1983 approved these changes
@zeapoz zeapoz zeapoz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kkovaacs @bobbinth @Mirko-von-Leipzig @partylikeits1983 @zeapoz @claude