perf(standards): skip conversion math for 1/1 fee rates - #3317
Draft
mmagician wants to merge 1 commit into
Draft
Conversation
Per review: a 1/1 rate converts trivially, so convert_amount returns the amount unchanged without the u64 multiply/divide chain. This is the common case for native fee payment. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mmagician
force-pushed
the
mmagician-claude/fee-rate-early-return
branch
from
July 16, 2026 11:22
1b4a228 to
6288f7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not ready - do not review yet
Summary
Addresses this review comment on #3298: a 1/1 conversion rate converts trivially, so
fee::convert_amountnow returns the amount unchanged without running the u64 multiply/divide chain. This is the common case for native fee payment (used by singlesig's trivial rate and, in the stacked PRs, by the network / no-auth wiring).No behavior change; rate validation still runs first, so the zero/non-u32 rate errors are unaffected.