feat(validator): only issue shares for validated transactions - #2533
Open
sergerad wants to merge 1 commit into
Open
feat(validator): only issue shares for validated transactions#2533sergerad wants to merge 1 commit into
sergerad wants to merge 1 commit into
Conversation
This was referenced Aug 31, 2026
sergerad
force-pushed
the
sergerad-validator-share-hardening
branch
2 times, most recently
from
August 31, 2026 02:28
649a1e4 to
5808530
Compare
sergerad
marked this pull request as ready for review
August 31, 2026 02:34
sergerad
force-pushed
the
sergerad-validator-share-hardening
branch
from
August 31, 2026 02:50
5808530 to
86dc8f1
Compare
The share endpoint would issue a decryption share over any well-formed ciphertext, acting as an unrestricted decryption oracle. Parse the decryption context (new canonical parser with strict domain, length, version, and transaction-id checks) and refuse unless it references a transaction this validator itself validated. Cross-validator recovery keeps working because every validator in the quorum validated the transaction. Share errors are now classified exhaustively so a new error variant must be triaged instead of silently becoming a 500. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
sergerad
force-pushed
the
sergerad-validator-share-hardening
branch
from
August 31, 2026 02:59
86dc8f1 to
7b992c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 3 of a 4-PR stack formalizing the validator admin API (#2455).
The share endpoint would issue a decryption share over any well-formed ciphertext, acting as an unrestricted decryption oracle.
PrivateRecordContext::try_from_bytes, a strict parser for the canonical v1 context (domain tag, field lengths, format version, canonical transaction id), with round-trip and rejection tests for every failure path.POST /admin/v1/decryption-shareparses the transaction id out of the request's decryption context and refuses (404) unless this validator itself validated that transaction. The context is cryptographically bound to the ciphertext, so an arbitrary ciphertext cannot be smuggled under a validated transaction's context. Cross-validator recovery keeps working: every validator in the quorum validated the transaction, and each still issues shares over ciphertexts it does not store.map_share_errornow matchesPrivateRecordErrorexhaustively, so a new variant — or agolden-ehtdh1upgrade that introduces a new failure — must be classified rather than silently becoming a 500.Stack: #2531 → #2532 → #2533 → #2517
Changelog