Repository navigation
feat(lsp): Language Server Protocol for skill frontmatter autocompletion (#27) - #46
Merged
Merged
Conversation
👋 Thanks for opening this pull request, @00200200!We're thrilled to have your contribution to cinch! Here is a quick checklist to help get your PR merged smoothly:
A maintainer will review your code shortly. Feel free to ping in comments if you have any questions! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #27
Summary of Changes
src/cinch/lsp.pyusing standard JSON-RPC 2.0 with Content-Length framing and NDJSON fallback.initialize,initialized,shutdown,exittextDocument/didOpen,textDocument/didChange,textDocument/didClosetextDocument/completion: provides completions for schema fields (ALLOWED_KEYS), dialect names, triggers, booleans, and glob patterns.textDocument/hover: provides markdown tooltips explaining harness-specific behavior and limitations.textDocument/publishDiagnostics: real-time frontmatter validation flagging syntax issues, unrecognized keys (with close match suggestions), missing/invalid name (kebab-case), description length boundaries, and glob validity.cinch lspsubcommand insrc/cinch/cli.pywith optional--strictmode.src/cinch/schema.pyfor common alias mappings (variables,compatibility,params,dependencies).tests/test_lsp.pycovering lifecycle, diagnostics, completion, hover, and stdio framing.