Add Codex CLI plugin manifest#3330
Conversation
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThis pull request adds two new configuration files to establish a Codex plugin setup for the project. A plugin manifest file is added to declare metadata, version information, and MCP server configuration. Concurrently, a GitHub Actions workflow is introduced to automatically scan the plugin against quality standards on push and pull request events to the main branch, failing when critical-severity issues are detected. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @internet-dot, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
| "mcp", | ||
| "codex" | ||
| ], | ||
| "mcpServers": "./.mcp.json" |
There was a problem hiding this comment.
🔴 plugin.json references non-existent .mcp.json file
The mcpServers field in .codex-plugin/plugin.json:15 points to ./.mcp.json, but this file does not exist anywhere in the repository root. The only MCP-related JSON file is .cursor/mcp.json (which lives in a different directory and has a different structure with an empty mcpServers object). This means the Codex plugin will fail to resolve its MCP server configuration, making the plugin non-functional.
Was this helpful? React with 👍 or 👎 to provide feedback.
| steps: | ||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
| - name: Codex plugin scanner | ||
| uses: hashgraph-online/hol-codex-plugin-scanner-action@e83708a91ae4812872aa2905b99ad559a55c74ab |
There was a problem hiding this comment.
🚩 Third-party GitHub Action from lesser-known organization
The workflow at .github/workflows/codex-plugin-scanner.yml:22 uses hashgraph-online/hol-codex-plugin-scanner-action@e83708a91ae4812872aa2905b99ad559a55c74ab. While it is correctly pinned to a commit SHA (good security practice, consistent with the actions/checkout pin on line 20), hashgraph-online is not a well-known or widely-adopted GitHub Actions publisher. The action runs with contents: read permissions which limits blast radius, but the action could still exfiltrate repository source code. Worth verifying this is an intentional and trusted dependency.
Was this helpful? React with 👍 or 👎 to provide feedback.
I opened this because trigger.dev – build and deploy fully‑managed AI agents and workflows.
What stood out from the repo:
This PR adds the basic Codex plugin metadata, an
.mcp.jsonstarting point, and the scanner workflow.If you want different command wiring or manifest metadata, I can adjust the branch.