Skip to content

ci: add Windows unit test job#394

Open
preko-p wants to merge 1 commit into
shipwright-io:mainfrom
preko-p:64-ci-testing-windows
Open

ci: add Windows unit test job#394
preko-p wants to merge 1 commit into
shipwright-io:mainfrom
preko-p:64-ci-testing-windows

Conversation

@preko-p

@preko-p preko-p commented Jun 8, 2026

Copy link
Copy Markdown

Summary

  • adds a separate test-unit-windows GitHub Actions job for Windows unit coverage
  • preserves the existing Linux test-unit job and status-check name unchanged
  • expands the existing make test-unit command directly with go test -mod=vendor -race -cover ./cmd/shp/... ./pkg/... so the Windows job does not depend on make

Fixes #64.

Testing

  • docker run --rm -v "$PWD":/workspace -w /workspace golang:1.25 go test -mod=vendor -race -cover ./cmd/shp/... ./pkg/...
  • docker run --rm -v "$PWD":/workspace -w /workspace golang:1.25 sh -c 'GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go build -mod=vendor ./cmd/shp/...'
  • git diff --check

Notes

The actual Windows unit test execution is intentionally left to upstream GitHub Actions. The existing Linux test-unit job remains unchanged so current branch protection/check names are not disturbed; maintainers can decide whether to make the new Windows job required.

This PR was prepared with AI assistance and reviewed before submission.

NONE

Copilot AI review requested due to automatic review settings June 8, 2026 17:29
@pull-request-size pull-request-size Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 8, 2026
@openshift-ci openshift-ci Bot requested review from adambkaplan and qu1queee June 8, 2026 17:29
@openshift-ci

openshift-ci Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign heavywombat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a Windows CI job to run Go unit tests alongside the existing unit-test workflow.

Changes:

  • Introduces a test-unit-windows job running on windows-latest
  • Sets up Go and runs go test with race detection and coverage on Windows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: preko-p <278021202+preko-p@users.noreply.github.com>
@preko-p preko-p force-pushed the 64-ci-testing-windows branch from c14a2ee to a7d30d4 Compare June 8, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

CI Testing for Windows

3 participants