ci: add Windows unit test job#394
Open
preko-p wants to merge 1 commit into
Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a Windows CI job to run Go unit tests alongside the existing unit-test workflow.
Changes:
- Introduces a
test-unit-windowsjob running onwindows-latest - Sets up Go and runs
go testwith race detection and coverage on Windows
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: preko-p <278021202+preko-p@users.noreply.github.com>
c14a2ee to
a7d30d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-unit-windowsGitHub Actions job for Windows unit coveragetest-unitjob and status-check name unchangedmake test-unitcommand directly withgo test -mod=vendor -race -cover ./cmd/shp/... ./pkg/...so the Windows job does not depend onmakeFixes #64.
Testing
docker run --rm -v "$PWD":/workspace -w /workspace golang:1.25 go test -mod=vendor -race -cover ./cmd/shp/... ./pkg/...docker run --rm -v "$PWD":/workspace -w /workspace golang:1.25 sh -c 'GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go build -mod=vendor ./cmd/shp/...'git diff --checkNotes
The actual Windows unit test execution is intentionally left to upstream GitHub Actions. The existing Linux
test-unitjob remains unchanged so current branch protection/check names are not disturbed; maintainers can decide whether to make the new Windows job required.This PR was prepared with AI assistance and reviewed before submission.