Repository navigation
Commit 472e372
committed
Deprecate Kernel#with in favor of instance_eval
Kernel#with(obj) { ... } is just a more readable spelling of
obj.instance_eval { ... }. Rails 7.1 added an unrelated Object#with that
temporarily sets attributes, and whichever loads last wins, so Facets'
version silently broke Rails' when both were loaded: with(name: "sue")
evaluated the block against the hash instead of setting name.
It now warns and is scheduled for removal after 2027-09-30, like the
other deprecations. The docs also claimed it worked like `returning`,
but it returns the block's value; they now say so.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01E2Njj4j1r9twkVcXsMySLW1 parent 1335864 commit 472e372
2 files changed
Lines changed: 15 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
| 3 | + | |
| 4 | + | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
11 | 10 | | |
| 11 | + | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
14 | 16 | | |
15 | 17 | | |
| 18 | + | |
| 19 | + | |
16 | 20 | | |
17 | 21 | | |
18 | 22 | | |
19 | 23 | | |
20 | | - | |
| |||
0 commit comments