fix(deps): Add missing transitive peerDependencies#48616
Open
fbartho wants to merge 2 commits into
Open
Conversation
Fixes: react#48615 Using yarn 3.6.4 (berry) on a new react-native project, I get the following dependency warnings: ```shell $ yarn ➤ YN0000: ┌ Resolution step ➤ YN0002: │ @react-native/babel-plugin-codegen@npm:0.76.6 doesn't provide @babel/preset-env (pda3fc), requested by @react-native/codegen ➤ YN0002: │ babel-plugin-transform-flow-enums@npm:0.0.2 doesn't provide @babel/core (pd2efd), requested by @babel/plugin-syntax-flow ➤ YN0002: │ react-native@npm:0.76.6 [24bb2] doesn't provide @babel/core (p230be), requested by babel-jest ➤ YN0002: │ react-native@npm:0.76.6 [24bb2] doesn't provide @babel/preset-env (pe8640), requested by @react-native/codegen ➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code ``` Of these, it appears babel-plugin-transform-flow-enums isn't provided by this repository, but the rest of them are. This commit bubbles up their peerDependency requirements into the appropriate package.json files
facebook-github-bot
added
CLA Signed
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
Stale
Contributor
Author
|
This PR was valid, I don’t know what to do to get it merged. I’m happy to update the branch if some maintainer offers to help get it merged, but if nobody with merge powers can help, I worry that’s a waste of limited time. |
Collaborator
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #48615
Using yarn 3.6.4 (berry) on a new react-native project, I get the following dependency warnings:
Of these, it appears babel-plugin-transform-flow-enums isn't provided by this repository, but the rest of them are.
This PR bubbles up their peerDependency requirements into the appropriate package.json files
Changelog:
[GENERAL] [FIXED] - Peer dependency warnings for Yarn 3
Test Plan:
corepack enable)yarn installOr use the reproducer: https://github.com/fbartho/react-native-peerDependencies-reproducer/