Commit d2ac190
Persist Change Bundle Location host setting (#57425)
Summary:
Persist `Change Bundle Location` updates to the same `debug_http_host` preference used by the Android Dev Settings screen.
Previously, `Change Bundle Location` only updated the in-memory `PackagerConnectionSettings` host override. After killing and restarting the app process, the host was read again from `SharedPreferences`, so the change was lost.
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[ANDROID] [FIXED] - Persist Change Bundle Location debug server host changes
Pull Request resolved: #57425
Test Plan:
Verified with RNTester `debugOptimized` on Android:
1. Installed and launched RNTester on a physical Android device.
2. Opened the React Native Dev Menu.
3. Changed the bundle location using `Change Bundle Location`.
4. Killed and restarted the app process.
5. Confirmed the updated host is still used after restart.
Reviewed By: cortinico
Differential Revision: D110990504
Pulled By: Abbondanzo
fbshipit-source-id: c5fa7ed011872df7f0f14a8a45a0a7a0e4d8658d1 parent 0df0be2 commit d2ac190
1 file changed
Lines changed: 4 additions & 1 deletion
File tree
- packages/react-native/ReactAndroid/src/main/java/com/facebook/react/packagerconnection
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
| 56 | + | |
55 | 57 | | |
56 | 58 | | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
| 62 | + | |
60 | 63 | | |
61 | 64 | | |
62 | 65 | | |
| |||
0 commit comments