Skip to content

extract unauthorized-from FlowTransferV1 helpers#459

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-05-07-issue-421-unauthorized-transfer-helpers
Open

extract unauthorized-from FlowTransferV1 helpers#459
thedavidmeister wants to merge 1 commit into
mainfrom
2026-05-07-issue-421-unauthorized-transfer-helpers

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Summary

Three negative-path tests in Flow.transfer.t.sol built two-element FlowTransferV1 structs inline with the same shape (one transfer unauthorized + one self-flow) repeated per token type.

Adds three helpers in FlowTransferOperation.sol:

  • unauthorizedERC20Flow
  • unauthorizedERC721Flow
  • unauthorizedERC1155Flow

Each takes the unauthorized address, the authorized actor, the flow, and per-type ids/amounts, and returns the full FlowTransferV1.

The matching inline blocks in the three negative-path tests are replaced. The second block in the ERC20 test (unauthorized at slot 1, not 0) keeps its inline construction since it exercises a different shape.

Closes #421.

Test plan

  • all 3 negative-path tests still pass — 100 fuzz runs each

🤖 Generated with Claude Code

Three negative-path tests in Flow.transfer.t.sol built two-element
FlowTransferV1 structs inline, with the same shape (one transfer
unauthorized + one self-flow) repeated per token type.

Adds three helpers in FlowTransferOperation.sol:
- unauthorizedERC20Flow
- unauthorizedERC721Flow
- unauthorizedERC1155Flow

Each takes the unauthorized address, the authorized actor, the flow,
and per-type ids/amounts, and returns the full FlowTransferV1.

The matching inline blocks in the three negative-path tests are
replaced. The second block in the ERC20 test (where the unauthorized
address is at slot 1, not 0) keeps its inline construction since it
exercises a different shape.

Closes #421.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 35 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ff48a312-36d4-4787-9358-f6b23d998bd1

📥 Commits

Reviewing files that changed from the base of the PR and between ceaea3c and 9e0082c.

📒 Files selected for processing (2)
  • test/abstract/FlowTransferOperation.sol
  • test/src/concrete/Flow.transfer.t.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-07-issue-421-unauthorized-transfer-helpers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister self-assigned this May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TEST-3] [LOW] Negative-path FlowTransferV1 construction duplicated in Flow.transfer.t.sol

1 participant