extract unauthorized-from FlowTransferV1 helpers#459
Conversation
Three negative-path tests in Flow.transfer.t.sol built two-element FlowTransferV1 structs inline, with the same shape (one transfer unauthorized + one self-flow) repeated per token type. Adds three helpers in FlowTransferOperation.sol: - unauthorizedERC20Flow - unauthorizedERC721Flow - unauthorizedERC1155Flow Each takes the unauthorized address, the authorized actor, the flow, and per-type ids/amounts, and returns the full FlowTransferV1. The matching inline blocks in the three negative-path tests are replaced. The second block in the ERC20 test (where the unauthorized address is at slot 1, not 0) keeps its inline construction since it exercises a different shape. Closes #421. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Three negative-path tests in
Flow.transfer.t.solbuilt two-elementFlowTransferV1structs inline with the same shape (one transfer unauthorized + one self-flow) repeated per token type.Adds three helpers in
FlowTransferOperation.sol:unauthorizedERC20FlowunauthorizedERC721FlowunauthorizedERC1155FlowEach takes the unauthorized address, the authorized actor, the flow, and per-type ids/amounts, and returns the full
FlowTransferV1.The matching inline blocks in the three negative-path tests are replaced. The second block in the ERC20 test (unauthorized at slot 1, not 0) keeps its inline construction since it exercises a different shape.
Closes #421.
Test plan
🤖 Generated with Claude Code