Repository navigation
Commit 1e0643d
Fix SO2/SE2.interp1(), which raised NameError for every input
The fix for #33 dropped the `start` local from interp1() but only replaced its
two uses in the N == 3 branch, so the SO(2)/SE(2) branch has referenced an
undefined name ever since:
SE2(1, 2, 0.3).interp1(0.5) # NameError: name 'start' is not defined
#33 did report it for both SE2 and SE3. Pass None like the N == 3 branch does;
trinterp2() already treats a None start as the identity. interp1() had no test
coverage for either dimension, hence the four years.1 parent 4d4196d commit 1e0643d
2 files changed
Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
522 | 522 | | |
523 | 523 | | |
524 | 524 | | |
525 | | - | |
| 525 | + | |
526 | 526 | | |
527 | 527 | | |
528 | | - | |
| 528 | + | |
529 | 529 | | |
530 | 530 | | |
531 | 531 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
466 | 466 | | |
467 | 467 | | |
468 | 468 | | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
469 | 486 | | |
470 | 487 | | |
471 | 488 | | |
| |||
0 commit comments