fix: preserve false default parameters

Author: pikasTech

docs/MDTODO/pikapython-syntax-compatibility.md

@@ -314,3 +314,7 @@ P0 修复空 import 与 from-import 缺名称在 Suger_import 路径的解析崩
 ### R14.5 [completed]
 
 继续解决 [#348](https://github.com/pikasTech/PikaPython/issues/348) 的 VM 性能债务：优化 kwargs 名称恢复中的常量池重复扫描，在不扩大语法、不改变 VM 大架构且不增加常驻 RAM 的前提下完成同机 A/B、default/minimal 资源和语义回归，完成任务后将详细报告写入[任务报告](./details/pikapython-syntax-compatibility/R14.5_Task_Report.md)。
+
+### R14.6 [in_progress]
+
+修复 Linux Action 暴露的默认参数名被误记为未绑定局部变量问题，覆盖 False 默认值和方法参数，完成隔离 Linux 回归并确认不扩大语法或 VM 架构，完成任务后将详细报告写入[任务报告](./details/pikapython-syntax-compatibility/R14.6_Task_Report.md)。

port/linux/test/pikaMain-test.cpp

@@ -540,7 +540,14 @@ TEST(pikaMain, python3_default_argument_definition_time) {
         "class DefaultOwner:\n"
         "    def value(self, item=4):\n"
         "        return item\n"
-        "class_default = DefaultOwner().value()\n");
+        "    def enabled(self, stop_on_error: bool=False):\n"
+        "        return stop_on_error\n"
+        "class_default = DefaultOwner().value()\n"
+        "method_false_default = DefaultOwner().enabled()\n"
+        "def false_default(stop_on_error=False):\n"
+        "    return stop_on_error\n"
+        "false_default_value = false_default()\n"
+        "false_default_override = false_default(True)\n");
 
     EXPECT_EQ(obj_getInt(globals, "default_first"), 101);
     EXPECT_EQ(obj_getInt(globals, "default_second"), 102);
@@ -549,6 +556,9 @@ TEST(pikaMain, python3_default_argument_definition_time) {
     EXPECT_EQ(obj_getInt(globals, "global_before"), 7);
     EXPECT_EQ(obj_getInt(globals, "global_value"), 8);
     EXPECT_EQ(obj_getInt(globals, "class_default"), 4);
+    EXPECT_EQ(obj_getInt(globals, "method_false_default"), 0);
+    EXPECT_EQ(obj_getInt(globals, "false_default_value"), 0);
+    EXPECT_EQ(obj_getInt(globals, "false_default_override"), 1);
 
     obj_deinit(pikaMain);
     EXPECT_EQ(pikaMemNow(), 0);

src/PikaVM.c

@@ -3636,7 +3636,8 @@ static pika_bool _methodLocalCandidate(char* name) {
 static void _methodStoreDefinitionMeta(PikaObj* context,
                                        PikaVMFrame* vm,
                                        Method method,
-                                       int def_block_deepth) {
+                                       int def_block_deepth,
+                                       char* declaration) {
     char key[2 + sizeof(uintptr_t) * 2 + 1] = {0};
     MethodDefinitionMeta meta = {0};
     uint32_t default_num = PikaVMFrame_getInputArgNum(vm);
@@ -3701,12 +3702,35 @@ static void _methodStoreDefinitionMeta(PikaObj* context,
         }
     }
 
+    Args parameter_names = {0};
+    Args parameter_buffs = {0};
+    char* parameters = strsCut(&parameter_buffs, declaration, '(', ')');
+    while (NULL != parameters && '\0' != parameters[0]) {
+        char* parameter = strPopFirstToken(&parameters, ',');
+        while ('*' == parameter[0]) {
+            parameter++;
+        }
+        char* end = strchr(parameter, ':');
+        if (NULL == end) {
+            end = strchr(parameter, '=');
+        }
+        if (NULL != end) {
+            end[0] = '\0';
+        }
+        if ('\0' != parameter[0]) {
+            args_setNone(&parameter_names, parameter);
+        }
+    }
     for (int i = args_getSize(meta.local_names) - 1; i >= 0; i--) {
         Arg* local_name = args_getArgByIndex(meta.local_names, i);
-        if (args_isArgExist_hash(global_names, arg_getNameHash(local_name))) {
+        Hash name_hash = arg_getNameHash(local_name);
+        if (args_isArgExist_hash(global_names, name_hash) ||
+            args_isArgExist_hash(&parameter_names, name_hash)) {
             args_removeArg(meta.local_names, local_name);
         }
     }
+    args_deinit_stack(&parameter_names);
+    strsDeinit(&parameter_buffs);
     args_deinit(global_names);
 
     if (0 == args_getSize(meta.local_names)) {
@@ -3765,7 +3789,7 @@ static Arg* __VM_instruction_handler_DEF(PikaObj* self,
     }
 
     if (!is_class && NULL != method) {
-        _methodStoreDefinitionMeta(self, vm, method, thisBlockDeepth);
+        _methodStoreDefinitionMeta(self, vm, method, thisBlockDeepth, data);
     }
 
     return NULL;