Skip to content
This repository was archived by the owner on Oct 18, 2026. It is now read-only.

build(deps): update Codex CLI and review provenance - #337

Open
steipete wants to merge 2 commits into
mainfrom
maintenance/clownfish-codex-update
Open

steipete wants to merge 2 commits into
mainfrom
maintenance/clownfish-codex-update

Conversation

@steipete

@steipete steipete commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Update worker and external-review Codex CLI defaults from 0.125.0 to 0.156.1, together with the external preflight’s pinned annotated source tag and commit. Derive negative versions, commit-tampering fixtures, clone assertions, and tag refs from the shared pin so future upgrades retain the provenance checks.

Validation at 373c806b7eb21a7353e8f28a2b39307ccf5bc06b:

  • AWS Crabbox, Node 24.18.1 and SQLite 3.46.1: installed @openai/codex@0.156.1 into an isolated prefix and launched the real Linux binary. Output: codex-cli 0.156.1.
  • Cloned annotated rust-v0.156.1 and verified tag object 81e8e29b2956dfe9b092c63953a9ed282781e77c, commit b412ff32c417f855c2b2d1581b77058eed87c84b, and all required source files. The binary exposes the JSONL, output schema, final-output file, ephemeral, and sandbox flags used here; upstream source retains the configured legacy Landlock feature.
  • npm run validate: 6,778 jobs passed. npm test: 739/739 passed, zero skips. Rendering, plan-mode worker dry run, offline artifact generation, all script syntax checks, and git diff --check passed.
  • Initial hosted validation caught two additional fixtures that still embedded the old tag/commit fragment. Those fixtures now derive their expectations from the shared pin; focused reruns and the full remote suite pass.
  • Independent Codex autoreview of the upgrade and follow-up fixture repair found no actionable P0–P2 findings.
  • Final exact-head hosted CI succeeded: validation and CodeQL.

Landing hold: the repository Actions variable CLOWNFISH_CODEX_CLI_VERSION currently pins 0.125.0 and overrides workflow defaults. The lead maintainer must coordinate its update to 0.156.1 with the new source pin while preventing preflights from crossing the mismatch window. The live variable has not been changed.

The runtime check used the actual binary but did not make an authenticated worker/preflight model call. Hosted review requests that canary; it remains part of the operator-owned rollout decision. Model selection and authentication are unchanged.

Awaiting lead-maintainer review. No release or automated merge is requested.

Update workflow defaults and the verified annotated source pin together to 0.156.1. Derive negative fixture versions and tag refs from the shared pin so provenance tests remain effective after upgrades.
@clawsweeper

clawsweeper Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Sep 23, 2026
@clawsweeper

clawsweeper Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex review: blocked before merge.

What this changes

This PR upgrades Codex CLI defaults and pinned review-source provenance to 0.156.1 and updates existing fixtures to follow the shared pin.

Example: An external OpenClaw preflight runs without an Actions version override.

  • Before: It installs Codex CLI 0.125.0 and verifies rust-v0.125.0.
  • After: It installs Codex CLI 0.156.1 and verifies rust-v0.156.1.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) The narrow patch preserves its contract and has successful exact-head validation, while runtime confidence stops at installation and source identity.
Proof confidence 🦐 gold shrimp (3/6) Under the supplied maintainer-authored classification, ordinary contributor proof is not a merge gate; the body records a real Linux binary launch and source verification but expressly excludes an authenticated worker/preflight model call.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Workers and external reviews remain on Codex CLI 0.125.0, and upgrading requires executable defaults and verified source provenance to remain aligned.
Reason: The supplied maintainer-authored classification establishes direction, and the focused upgrade preserves existing configuration controls, authentication wiring, and provenance safeguards.

Merge readiness

⛔ Blocked before merge - 2 items remain

Keep this PR open: the focused dependency upgrade remains absent from main, and no actionable patch defect was found; the reported merge conflict and coordinated operator cutover still block landing.

Priority: P2
Reviewed head: 373c806b7eb21a7353e8f28a2b39307ccf5bc06b

Before merge

  • Resolve merge risk - Before landing, an operator must verify CLOWNFISH_CODEX_CLI_VERSION and coordinate its switch to 0.156.1 with the source pin while preventing affected preflights from running across the mismatch window.
  • Complete next step - Resolve GitHub's reported merge conflict against current main while preserving the aligned executable and source pins.

Findings

None.

Tests

  • Missing end-to-end proof: The supplied runtime check does not exercise an authenticated worker/preflight model call with aligned 0.156.1 executable and source pins.
Agent review details

How this fits together

GitHub workflows install Codex for workers and external preflights; preflight binds structured review evidence to verified upstream source, and result validation checks that provenance before merge application.

flowchart LR
A[Workflow version setting] --> B[Codex installation]
B --> C[Worker or external preflight]
D[Pinned upstream source] --> C
C --> E[Structured review evidence]
E --> F[Provenance validation]
F --> G[Merge application]
Loading

Technical review

Best possible solution:

Land matching executable and source pins through a coordinated operator cutover.

Do we have a high-confidence way to reproduce the issue?

This is dependency maintenance; source establishes the executable/source mismatch rejection path without requiring a failing runtime reproduction.

Is this the best way to solve the issue?

Updating executable defaults and verified source identity together is appropriately narrow, and the fixture edits preserve the existing rejection contract.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against c10506316c37.

Merge-risk options

Maintainer options:

  1. Coordinate the operator cutover (recommended)
    Verify the Actions override, pause affected preflights, and deploy matching executable and source pins before resuming them.
  2. Retain the landing hold
    Keep 0.125.0 on main until an operator can coordinate the upgrade.

Provenance checked

  • Pinned dependency and provenance fixtures keeps the original intent (91cdd3b: Bind review evidence to exact annotated Codex source and reject invalid provenance before mutation, as documented in fix(preflight): pin Codex review source #315.)
  • Worker CLI installation keeps the original intent (4fd6bc4: Cache a version-controlled Codex installation for cluster workers.)
  • External preflight CLI installation keeps the original intent (5815ddf: Provide external merge preflight with an installed Codex runtime.)
  • Batch worker CLI default keeps the original intent (b67635b: Support plan-batch fan-out using the worker runtime.)
  • Finding-intake CLI default keeps the original intent (6acdbf9: Run ClawSweeper commit-finding intake.)
  • Local-run documentation keeps the original intent (b9098f1: Document public-safe local operation.)

Testing

Proof path: in-process harness.

Security

None.

Evidence

What I checked:

  • Introduced change: The pinned introduced diff updates executable defaults and the annotated-source tuple together; production provenance validation remains unchanged, and existing rejection fixtures retain malformed-version and tampering coverage. (scripts/codex-review-dependency.mjs:4, 373c806b7eb2)
  • Current-main necessity: The live default branch matches the supplied main revision and still pins 0.125.0; searches for 0.156.1, Codex upgrade, and Codex CLI found no competing item owning this upgrade. (scripts/codex-review-dependency.mjs:4, c10506316c37)
  • Operator cutover: The complete PR body reports that the unchanged Actions override pins 0.125.0 and explicitly holds landing. Workflow overrides take precedence over defaults, while preflight rejects a binary version unequal to the source pin. The variables endpoint returned 403, so the live value requires operator verification. (scripts/preflight-external-pr-merge.mjs:2145, 373c806b7eb2)
  • Live merge state: GitHub reports the reviewed head as open, mergeable false, and mergeable_state dirty. (373c806b7eb2)
  • Exact-head validation: The linked validation and CodeQL runs succeeded on the reviewed head. The cancelled dispatch job contains no steps and establishes no diff-caused failure. (373c806b7eb2)
  • Original provenance contract: fix(preflight): pin Codex review source #315 introduced exact annotated-source identity and citation-bound evidence before mutation. Its maintainer discussion accepted blocking when pinned source is unavailable; that decision does not settle this upgrade's version cutover. (scripts/codex-review-dependency.mjs:29, 91cdd3bc8800)

Likely related people:

  • Vincent Koc: Raw commit 91cdd3b adds scripts/codex-review-dependency.mjs:3 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: 91cdd3bc8800; files: scripts/codex-review-dependency.mjs)
  • Peter Steinberger: Raw commit 7637544 adds .github/workflows/cluster-worker.yml:285 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: 763754415310; files: .github/workflows/cluster-worker.yml)

Labels

Label changes:

No label changes.

Label justifications:

  • P2: This is bounded dependency maintenance with no demonstrated urgent user regression.
  • merge-risk: 🚨 automation: A retained 0.125.0 Actions override would make external preflight reject the new 0.156.1 source pin.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: ⏳ waiting on author: ClawSweeper has contributor-facing work open and is waiting for author action.

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

  • Optionally record an authenticated worker/preflight canary with aligned 0.156.1 executable and source pins, redacting credentials and private endpoints.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

History

Review history (9 earlier review cycles; latest 8 shown)
  • reviewed 2026-09-23T08:13:44.464Z sha 373c806 :: needs real behavior proof before merge. :: none
  • reviewed 2026-10-02T05:01:59.798Z sha 373c806 :: blocked before merge. :: none
  • reviewed 2026-10-08T10:34:43.244Z sha 373c806 :: blocked before merge. :: none
  • reviewed 2026-10-10T12:56:30.464Z sha 373c806 :: blocked before merge. :: none
  • reviewed 2026-10-10T17:44:27.558Z sha 373c806 :: blocked before merge. :: none
  • reviewed 2026-10-10T22:28:12.619Z sha 373c806 :: blocked before merge. :: none
  • reviewed 2026-10-11T02:46:24.942Z sha 373c806 :: blocked before merge. :: none
  • reviewed 2026-10-11T13:05:48.160Z sha 373c806 :: blocked before merge. :: none

Reviewed October 12, 2026, 1:12 AM ET / 05:12 UTC (Revision 10).

@steipete
steipete marked this pull request as ready for review September 23, 2026 08:02
@steipete
steipete requested a review from vincentkoc September 23, 2026 08:02
@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Sep 23, 2026
@clawsweeper clawsweeper Bot added status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. and removed status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. labels Oct 2, 2026
@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. and removed status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. rating: 🦞 diamond lobster Very strong PR readiness with only minor maintainer review expected. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. labels Oct 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

merge-risk: 🚨 automation 🚨 Merging this PR could break CI, automerge, proof capture, label sync, or automation. P2 Normal priority bug or improvement with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: ⏳ waiting on author ClawSweeper has contributor-facing work open and is waiting for author action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant