You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
docs: reduce the PR template to the issues-not-PRs banner - #4961
Reduces .github/pull_request_template.md to the Heads up banner alone. Pull requests are turned off in the repository settings once #4939 lands on main, so the template's one job is the notice that turns outside PRs away. Dropped: the HTML comment restating the policy (it duplicated the banner) and the maintainers' body skeleton and checklist.
Maintainers never used the template text directly (pr-flow writes the body to a file and passes --body-file), but the rules pointed at its structure, so that structure moves:
pr-flow step 6 now lists the body's sections and the full checklist (all nine items, including the changeset line), and step 5 points at the body's How Has This Been Tested? section rather than the template's.
AGENTS.md: the checklist rule states the checklist in the body and points to pr-flow for the sections; the project-structure entry for the template and the version-PR exception ("the template checklist") are updated.
client-smoke's "the PR checklist" references are unchanged: they remain true of the checklist's new home.
Once merged, .github/pull_request_template.md on #4939's branch is re-synced from v2/main.
No client-observable surface; targeted probes, in a fresh worktree of this branch after npm ci:
npm run validate:guards exits 0 (root format check and lint, every verify:* guard, and test:scripts).
npm run verify:skills:cli exits 0 ("Validation passed"); verify:skills exits 0.
git grep -n -i "pull_request_template\|template checklist\|template's" finds no remaining reference that relies on the template's sections or checklist; the remaining hits describe it as the banner.
npm run skills:eval not run: no skill's description changed, only the body of pr-flow.
Pull requests are turned off once #4939 lands on main, so the template's
only job is the notice that turns outside PRs away. Drop the policy
comment, which duplicated the banner, and the maintainers' body skeleton
and checklist. The sections and the full checklist move to pr-flow step
6, and AGENTS.md's checklist rule, tree entry and version-PR exception
point there instead of at the template.
Closes#4960
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Issue #4960 explicitly requires AGENTS.md to state the checklist itself so references such as client-smoke resolve to the always-loaded rule. This summary retains only four of nine items and delegates the full list to a conditional skill, omitting the changeset, style, tests, error-handling, and configuration checks. Please copy the complete checklist here as well.
Takes .github/pull_request_template.md from v2/main, which reduced it to
the issues-not-PRs banner (#4960), so this branch stays byte-identical
to v2/main.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: cliffhall <cliff@futurescale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4960
Description
Reduces
.github/pull_request_template.mdto the Heads up banner alone. Pull requests are turned off in the repository settings once #4939 lands onmain, so the template's one job is the notice that turns outside PRs away. Dropped: the HTML comment restating the policy (it duplicated the banner) and the maintainers' body skeleton and checklist.Maintainers never used the template text directly (
pr-flowwrites the body to a file and passes--body-file), but the rules pointed at its structure, so that structure moves:pr-flowstep 6 now lists the body's sections and the full checklist (all nine items, including the changeset line), and step 5 points at the body's How Has This Been Tested? section rather than the template's.AGENTS.md: the checklist rule states the checklist in the body and points topr-flowfor the sections; the project-structure entry for the template and the version-PR exception ("the template checklist") are updated.client-smoke's "the PR checklist" references are unchanged: they remain true of the checklist's new home.Once merged,
.github/pull_request_template.mdon #4939's branch is re-synced fromv2/main.Server Details
AGENTS.md,pr-flowskillMotivation and Context
See #4960.
How Has This Been Tested?
No client-observable surface; targeted probes, in a fresh worktree of this branch after
npm ci:npm run validate:guardsexits 0 (root format check and lint, everyverify:*guard, andtest:scripts).npm run verify:skills:cliexits 0 ("Validation passed");verify:skillsexits 0.git grep -n -i "pull_request_template\|template checklist\|template's"finds no remaining reference that relies on the template's sections or checklist; the remaining hits describe it as the banner.npm run skills:evalnot run: no skill's description changed, only the body ofpr-flow.Breaking Changes
None.
Types of changes
Checklist
🤖 Generated with Claude Code