From b12575b0ab3fc8be878f47db2a46990433875e7c Mon Sep 17 00:00:00 2001 From: xnacly <47723417+xnacly@users.noreply.github.com> Date: Wed, 3 Jun 2026 17:37:42 +0200 Subject: [PATCH] ci(v4-beta): pin internal setup-msvc-dev-cmd ref to @v4-beta While testing the MSVC + DISTUTILS_USE_SDK chain end-to-end against v4-beta from runenv-python-3 PR #88, the workflow files still pinned the internal `setup-msvc-dev-cmd` ref to `@v4`. That meant downstream consumers picked up the v4-beta WORKFLOW but the v4 ACTION (no DISTUTILS_USE_SDK), so setuptools still raised the "Microsoft Visual C++ 14.0 or greater is required" error. Bumps both node-matrix.yaml and node-matrix-pnpm.yaml to reference `setup-msvc-dev-cmd@v4-beta` so the full chain is on v4-beta. This is a TEMPORARY pin: when v4-beta -> v4 promotion happens (through the standard merge-beta flow), the ref should flip back to `@v4`. --- .github/workflows/node-matrix-pnpm.yaml | 2 +- .github/workflows/node-matrix.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/node-matrix-pnpm.yaml b/.github/workflows/node-matrix-pnpm.yaml index 62ed186d..3af3ba74 100644 --- a/.github/workflows/node-matrix-pnpm.yaml +++ b/.github/workflows/node-matrix-pnpm.yaml @@ -656,7 +656,7 @@ jobs: # on non-Windows runners. - name: Setup MSVC Dev Cmd if: runner.os == 'Windows' - uses: milaboratory/github-ci/actions/setup-msvc-dev-cmd@v4 + uses: milaboratory/github-ci/actions/setup-msvc-dev-cmd@v4-beta with: arch: ${{ matrix.arch == 'arm64' && 'arm64' || 'amd64' }} diff --git a/.github/workflows/node-matrix.yaml b/.github/workflows/node-matrix.yaml index 6373f289..18622987 100644 --- a/.github/workflows/node-matrix.yaml +++ b/.github/workflows/node-matrix.yaml @@ -495,7 +495,7 @@ jobs: # on non-Windows runners. - name: Setup MSVC Dev Cmd if: runner.os == 'Windows' - uses: milaboratory/github-ci/actions/setup-msvc-dev-cmd@v4 + uses: milaboratory/github-ci/actions/setup-msvc-dev-cmd@v4-beta with: arch: ${{ matrix.arch == 'arm64' && 'arm64' || 'amd64' }}