Found during the 0.10.0-bug-bash-1 bug bash.
Summary
The index hide and unhide experience does not provide a consistent visual or tooltip model for the index state and the action that will occur.
Verified implementation details
IndexItem.getTreeItem() uses the same generic combine icon for hidden and visible indexes.- The Hide Index and Unhide Index commands in
package.json do not declare command icons.
- The context menu correctly shows Hide only for visible indexes and Unhide only for hidden indexes.
- The prior, currently commented-out tooltip action design used
eye-closed for Hide and eye for Unhide, with result-oriented hover text:
- Hide:
Hide this index from queries
- Unhide:
Make this index visible
The current state indication is limited to the localized (hidden) description and the detailed tree-item tooltip. It does not align iconography with the context-menu action.
Steps to reproduce
- Open a collection's Indexes node.
- Compare a visible index and a hidden index.
- Open the context menu for each index and inspect the Hide or Unhide action, its iconography, and tooltip.
Expected
The index icon, context-menu icon, and hover text consistently communicate both the current state and the action:
- Visible index: use a visible-eye state icon and an action such as
Hide index from queries.
- Hidden index: use an eye-closed state icon and an action such as
Make index visible to queries.
The command tooltip should describe the action that will happen, not conflict with the state represented by the icon.
Actual
Both states show the generic combine icon. Hide and Unhide actions have no dedicated command icons, and the useful state/action icon and tooltip mapping exists only in commented-out code.
Suggested fix
Define explicit ThemeIcons for the Hide Index and Unhide Index commands in package.json, and assign state-specific icons to tree items. Use localized action-oriented command titles or tooltips that match the icon and the command's result. Add focused tests for visible and hidden index presentations.
Found during the
0.10.0-bug-bash-1bug bash.Summary
The index hide and unhide experience does not provide a consistent visual or tooltip model for the index state and the action that will occur.
Verified implementation details
IndexItem.getTreeItem()uses the same genericcombineicon for hidden and visible indexes.package.jsondo not declare command icons.eye-closedfor Hide andeyefor Unhide, with result-oriented hover text:Hide this index from queriesMake this index visibleThe current state indication is limited to the localized
(hidden)description and the detailed tree-item tooltip. It does not align iconography with the context-menu action.Steps to reproduce
Expected
The index icon, context-menu icon, and hover text consistently communicate both the current state and the action:
Hide index from queries.Make index visible to queries.The command tooltip should describe the action that will happen, not conflict with the state represented by the icon.
Actual
Both states show the generic
combineicon. Hide and Unhide actions have no dedicated command icons, and the useful state/action icon and tooltip mapping exists only in commented-out code.Suggested fix
Define explicit ThemeIcons for the Hide Index and Unhide Index commands in
package.json, and assign state-specific icons to tree items. Use localized action-oriented command titles or tooltips that match the icon and the command's result. Add focused tests for visible and hidden index presentations.