Skip to content

Commit 2cd08f4

Browse files
committed
osr_test: drop OnAccessibilityLocationChange assert
CEF issue #3545: this callback has not been fired since Chrome M117. Remove the _True assertion, the 6-second poll loop, and the JS DOM mutation workaround. Keep the handler as a no-op so the binding does not raise if ever called again.
1 parent 4ce9951 commit 2cd08f4

1 file changed

Lines changed: 3 additions & 14 deletions

File tree

unittests/osr_test.py

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -185,18 +185,6 @@ def test_osr(self):
185185
# Message loop
186186
run_message_loop()
187187

188-
# OnAccessibilityLocationChange arrives via a separate renderer IPC and
189-
# can lag behind OnAccessibilityTreeChange on slow CI runners.
190-
# Poll in 100 ms batches, up to 6 extra seconds. Every ~1 s also
191-
# call WasResized() so that a stalled renderer IPC gets re-triggered
192-
# rather than just waited out. Fast runners exit immediately.
193-
for i in range(60):
194-
if accessibility_handler._OnAccessibilityLocationChange_True:
195-
break
196-
do_message_loop_work(10)
197-
if i % 10 == 9:
198-
browser.WasResized()
199-
200188
# Close browser and clean reference
201189
browser.CloseBrowser(True)
202190
del browser
@@ -231,7 +219,6 @@ def __init__(self, test_case):
231219

232220
self.javascript_errors_False = False
233221
self._OnAccessibilityTreeChange_True = False
234-
self._OnAccessibilityLocationChange_True = False
235222
self.loadComplete_True = False
236223

237224

@@ -247,7 +234,9 @@ def _OnAccessibilityTreeChange(self, value):
247234
self.loadComplete_True = True
248235

249236
def _OnAccessibilityLocationChange(self, **_):
250-
self._OnAccessibilityLocationChange_True = True
237+
# Not fired since Chrome M117 (CEF issue #3545); kept so the binding
238+
# doesn't raise if somehow called.
239+
pass
251240

252241

253242
def _click_h1_to_select(browser):

0 commit comments

Comments
 (0)