From e72f3c77a52a73d1dade60e604f3520e4d445771 Mon Sep 17 00:00:00 2001 From: jmsche Date: Wed, 10 Jun 2026 15:40:39 +0200 Subject: [PATCH] Upgrade GitHub workflows dependencies, test against Symfony 8.1 & update PHPStan baseline --- .github/workflows/build-docs.yaml | 2 +- .github/workflows/coding-standards.yaml | 4 ++-- .github/workflows/continuous-integration.yaml | 11 ++++------- .github/workflows/static-analysis.yaml | 4 ++-- .github/workflows/zizmor.yaml | 2 +- phpstan-baseline.neon | 18 ++++++++++++++++++ 6 files changed, 28 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build-docs.yaml b/.github/workflows/build-docs.yaml index 4d3d19c..27437c9 100644 --- a/.github/workflows/build-docs.yaml +++ b/.github/workflows/build-docs.yaml @@ -18,7 +18,7 @@ jobs: contents: write # Required to deploy steps: - name: Checkout code - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 with: persist-credentials: true diff --git a/.github/workflows/coding-standards.yaml b/.github/workflows/coding-standards.yaml index f386d86..b88b49a 100644 --- a/.github/workflows/coding-standards.yaml +++ b/.github/workflows/coding-standards.yaml @@ -25,12 +25,12 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 with: persist-credentials: false - name: Install PHP - uses: shivammathur/setup-php@7c071dfe9dc99bdf297fa79cb49ea005b9fcadbc # 2.37.1 + uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2 with: coverage: none php-version: ${{ matrix.php-version }} diff --git a/.github/workflows/continuous-integration.yaml b/.github/workflows/continuous-integration.yaml index 79a5be2..b3f8701 100644 --- a/.github/workflows/continuous-integration.yaml +++ b/.github/workflows/continuous-integration.yaml @@ -29,20 +29,17 @@ jobs: symfony-version: - '7.4.*' - '8.0.*' - include: - - php-version: '8.5' - symfony-version: '8.1.*@dev' - continue-on-error: true + - '8.1.*' steps: - name: Checkout code - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 with: persist-credentials: false fetch-depth: 2 - name: Install PHP with pcov - uses: shivammathur/setup-php@7c071dfe9dc99bdf297fa79cb49ea005b9fcadbc # 2.37.1 + uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2 with: coverage: pcov php-version: ${{ matrix.php-version }} @@ -60,5 +57,5 @@ jobs: run: vendor/bin/phpunit --coverage-clover=coverage.xml - name: Upload to Codecov - uses: codecov/codecov-action@e79a6962e0d4c0c17b229090214935d2e33f8354 # v6.0.1 + uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f # v7.0.0 if: matrix.php-version == '8.4' && matrix.symfony-version == '7.4.*' diff --git a/.github/workflows/static-analysis.yaml b/.github/workflows/static-analysis.yaml index a064779..c3406c8 100644 --- a/.github/workflows/static-analysis.yaml +++ b/.github/workflows/static-analysis.yaml @@ -25,12 +25,12 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 with: persist-credentials: false - name: Install PHP - uses: shivammathur/setup-php@7c071dfe9dc99bdf297fa79cb49ea005b9fcadbc # 2.37.1 + uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2 with: coverage: none php-version: ${{ matrix.php-version }} diff --git a/.github/workflows/zizmor.yaml b/.github/workflows/zizmor.yaml index df7db05..d80d6c1 100644 --- a/.github/workflows/zizmor.yaml +++ b/.github/workflows/zizmor.yaml @@ -23,7 +23,7 @@ jobs: runs-on: ubuntu-24.04 steps: - name: Checkout repository - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 + uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 with: persist-credentials: false diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index cc95016..ac316fb 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -156,6 +156,15 @@ parameters: count: 1 path: tests/LeaptCoreTestingKernel.php + - + rawMessage: ''' + Return type of method Leapt\CoreBundle\Tests\LeaptCoreTestingKernel::registerBundles() has typehint with deprecated interface Symfony\Component\HttpKernel\Bundle\BundleInterface: + since Symfony 8.1, use Symfony\Component\DependencyInjection\Kernel\BundleInterface instead + ''' + identifier: return.deprecatedInterface + count: 1 + path: tests/LeaptCoreTestingKernel.php + - rawMessage: 'Property Leapt\CoreBundle\Tests\Listener\Fixtures\Entity\User::$id is never written, only read.' identifier: property.onlyRead @@ -167,3 +176,12 @@ parameters: identifier: property.onlyRead count: 1 path: tests/Paginator/Entity/Player.php + + - + rawMessage: ''' + Call to deprecated method validate() of interface Symfony\Component\Validator\ConstraintValidatorInterface: + since Symfony 8.1, use "validateInContext()" instead + ''' + identifier: method.deprecated + count: 4 + path: tests/Validator/SlugValidatorTest.php