test: Model value-only overrides as flags served by fallthrough

Author: kinyoklion

lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/LDClientOverridesTest.java

@@ -57,7 +57,7 @@ public class LDClientOverridesTest extends BaseTest {
   private static final LDValue DEFAULT = LDValue.of("default");
 
   private static FeatureFlag valueFlag(String key, String value) {
-    return flagBuilder(key).version(1).on(false).offVariation(0).variations(LDValue.of(value)).build();
+    return flagBuilder(key).version(1).on(true).fallthroughVariation(0).variations(LDValue.of(value)).build();
   }
 
   private LDConfig.Builder configWith(DataSystemBuilder dataSystem) {
@@ -81,7 +81,7 @@ private LDConfig uninitializedConfig(ComponentConfigurer<OverrideSource> source)
   private static void assertOverrideServed(EvaluationDetail<LDValue> detail, String value) {
     assertEquals(LDValue.of(value), detail.getValue());
     assertEquals(0, detail.getVariationIndex());
-    assertEquals(EvaluationReason.off().withOverrideAffected(true), detail.getReason());
+    assertEquals(EvaluationReason.fallthrough().withOverrideAffected(true), detail.getReason());
   }
 
   private static void assertNotReady(EvaluationDetail<LDValue> detail) {
@@ -130,7 +130,7 @@ public void overrideTakesPrecedenceOverLaunchDarklyDataAndOtherFlagsAreUnaffecte
       assertOverrideServed(client.jsonValueVariationDetail("shared", CONTEXT, DEFAULT), "override-value");
       EvaluationDetail<LDValue> plain = client.jsonValueVariationDetail("plain", CONTEXT, DEFAULT);
       assertEquals(LDValue.of("plain-value"), plain.getValue());
-      assertEquals(EvaluationReason.off(), plain.getReason());
+      assertEquals(EvaluationReason.fallthrough(), plain.getReason());
       assertFalse(plain.getReason().isOverrideAffected());
 
       // Removing the override returns the flag to LaunchDarkly data.

lib/sdk/server/src/test/java/com/launchdarkly/sdk/server/OverrideSpecVectorsTest.java

@@ -59,9 +59,11 @@ static Iterable<Map.Entry<DataKind, KeyedItems<ItemDescriptor>>> collectionsFrom
       flagItems.add(new AbstractMap.SimpleEntry<>(key, FEATURES.deserialize(flags.get(key).toJsonString())));
     }
     for (String key : flagValues.keys()) {
-      // A value-only entry is a flag that is off and serves the value as its single variation.
-      LDValue flag = LDValue.buildObject().put("key", key).put("version", 0).put("on", false)
-          .put("offVariation", 0).put("variations", LDValue.buildArray().add(flagValues.get(key)).build()).build();
+      // A value-only entry is a flag that is on and serves the value as its single variation by
+      // fallthrough.
+      LDValue flag = LDValue.buildObject().put("key", key).put("version", 0).put("on", true)
+          .put("variations", LDValue.buildArray().add(flagValues.get(key)).build())
+          .put("fallthrough", LDValue.buildObject().put("variation", 0).build()).build();
       flagItems.add(new AbstractMap.SimpleEntry<>(key, FEATURES.deserialize(flag.toJsonString())));
     }
     List<Map.Entry<String, ItemDescriptor>> segmentItems = new ArrayList<>();

lib/sdk/server/src/test/resources/override-vectors/vectors.json

@@ -30,7 +30,7 @@
       "expect": {
         "value": "override-value",
         "variationIndex": 0,
-        "reason": { "kind": "OFF", "overrideAffected": true },
+        "reason": { "kind": "FALLTHROUGH", "overrideAffected": true },
         "summaryOverrideAffected": true
       }
     },
@@ -53,7 +53,7 @@
       "expect": {
         "value": "override-value",
         "variationIndex": 0,
-        "reason": { "kind": "OFF", "overrideAffected": true },
+        "reason": { "kind": "FALLTHROUGH", "overrideAffected": true },
         "summaryOverrideAffected": true
       }
     },