File: crates/state/src/tests/permissions.rs:1196
Severity: tech-debt
Obvious? yes
crates/state/src/tests/permissions.rs has *_by_kicked_member_is_rejected tests for SetProfile (line 1196), UpdateProfile (1319), PinMessage (1491), and UnpinMessage (1683), but no parallel coverage for the four chat-channel event kinds: Message, EditMessage, DeleteMessage, Reaction. These are the most-emitted events in the system, and the e2e/permissions.spec.ts:77 Playwright test (a 30+ second multi-peer round-trip) is the only thing currently asserting that a kicked peer's Message is dropped. Per CLAUDE.md "Adding a new EventKind" rule + the decision tree §1.
Fix: add four state-tier tests in permissions.rs: message_by_kicked_member_is_rejected, edit_message_by_kicked_member_is_rejected, delete_message_by_kicked_member_is_rejected, reaction_by_kicked_member_is_rejected — each grants membership, kicks the member via Propose/Vote, then asserts apply_incremental returns the MemberKicked rejection. Sub-millisecond per test vs. the current 30-second Playwright roundtrip.
Filed by /general-audit @ 88498a5 (2026-05-04). master: #600.
File:
crates/state/src/tests/permissions.rs:1196Severity: tech-debt
Obvious? yes
crates/state/src/tests/permissions.rshas*_by_kicked_member_is_rejectedtests forSetProfile(line 1196),UpdateProfile(1319),PinMessage(1491), andUnpinMessage(1683), but no parallel coverage for the four chat-channel event kinds:Message,EditMessage,DeleteMessage,Reaction. These are the most-emitted events in the system, and thee2e/permissions.spec.ts:77Playwright test (a 30+ second multi-peer round-trip) is the only thing currently asserting that a kicked peer'sMessageis dropped. Per CLAUDE.md "Adding a new EventKind" rule + the decision tree §1.Fix: add four state-tier tests in
permissions.rs:message_by_kicked_member_is_rejected,edit_message_by_kicked_member_is_rejected,delete_message_by_kicked_member_is_rejected,reaction_by_kicked_member_is_rejected— each grants membership, kicks the member viaPropose/Vote, then assertsapply_incrementalreturns theMemberKickedrejection. Sub-millisecond per test vs. the current 30-second Playwright roundtrip.Filed by
/general-audit@88498a5(2026-05-04). master: #600.