Skip to content

Consuming applications need to have core-js available. #2579

@buckett

Description

@buckett

Important note: if you are an Instructure employee please use Slack for bug reports/questions/feature requests. We can assist you much quicker and easier that way. If you are a third party user please ignore this message.

Background Information

Package Version(s): 11.4.0

OS: MacOS

Device: MacBook

Component: ui-emotion

Describe the Bug

Applications using Instructure UI need to have core-js available as a dependency.

Steps To Reproduce

When building a local application I was getting an error:

Error: [vite]: Rolldown failed to resolve import "core-js/modules/es.array.includes.js" from ".../node_modules/@instructure/emotion/es/styleUtils/calcSpacingFromShorthand.js".
This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rolldownOptions.external`

Expected Behavior

core-js shouldn't be required by calling applications.

Screenshots

Additional Information

Current Workaround(s): Add core-js as an explicit dependency.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions