From 150565868a6eb11f47ace90b00e333947e973eff Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Wed, 5 Feb 2025 15:09:59 +0100 Subject: [PATCH 1/3] fix typos --- v2-migration-guide.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/v2-migration-guide.md b/v2-migration-guide.md index 069f577..d7b2fa9 100644 --- a/v2-migration-guide.md +++ b/v2-migration-guide.md @@ -38,7 +38,7 @@ ## Signing a message -Use `createSigner` to construct a signer function. There are multiple ways to create a signer function, for example `createSigner.fromEthersWallet` can construct a signer from an `ethers.Walllet` +Use `createSigner` to construct a signer function. There are multiple ways to create a signer function, for example `createSigner.fromEthersWallet` can construct a signer from an `ethers.Wallet` ```ts import { createSigner, guild } from "@guildxyz/sdk"; @@ -100,7 +100,7 @@ const guildMembership = userMemberships.find( #### `join` -Use the `actions.join` client. Create a new join action with `actions.join.start`, then poll it's state by either calling `actions.join.poll`, or `actions.join.await`. The former will make a single poll, while the latter will keep polling the state until the job is done +Use the `actions.join` client. Create a new join action with `actions.join.start`, then poll its state by either calling `actions.join.poll`, or `actions.join.await`. The former will make a single poll, while the latter will keep polling the state until the job is done ```ts import { actions } from "@guildxyz/sdk"; @@ -215,7 +215,7 @@ await guild.delete(someGuildId, mySigner); #### `get` -Use `guild.role.get`. It now needs a `guildIdOrUrlName` param as well, and optionally takes a signer for more detailed results. The `guildId`, `members`, `requirements` and `rolePlatforms` fields aren't included in the result anymore. `guildId` is assumed to be known, as it is needed to make the get call, the other three can be fetched sepatarately with `guild.getMembers`, `guild.role.requirement.getAll` and `guild.role.reward.getAll` +Use `guild.role.get`. It now needs a `guildIdOrUrlName` param as well, and optionally takes a signer for more detailed results. The `guildId`, `members`, `requirements` and `rolePlatforms` fields aren't included in the result anymore. `guildId` is assumed to be known, as it is needed to make the get call, the other three can be fetched separately with `guild.getMembers`, `guild.role.requirement.getAll` and `guild.role.reward.getAll` ```ts import { guild } from "@guildxyz/sdk"; From 9b7e0598b2a2580fffc5ba8f47000abcdd1fafe3 Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Wed, 5 Feb 2025 15:11:42 +0100 Subject: [PATCH 2/3] fix typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 91d4d31..37cc42f 100644 --- a/README.md +++ b/README.md @@ -544,7 +544,7 @@ const signerFunction = createSigner.fromEthersWallet(wallet); await guildClient.guild.create( { name: "My New Guild", - urlName: "my-new-guild-123", // Optinal + urlName: "my-new-guild-123", // Optional description: "Cool stuff", // Optional admins: ["0x916b1aBC3C38852B338a22B08aF19DEe14113627"], // Optional showMembers: true, // Optional From 89a9b0a56450acfd875871cb259436e99a3327c3 Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Wed, 5 Feb 2025 15:12:31 +0100 Subject: [PATCH 3/3] fix typos --- examples/custom-point-distribution/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/custom-point-distribution/README.md b/examples/custom-point-distribution/README.md index 2f3d9f7..53fa035 100644 --- a/examples/custom-point-distribution/README.md +++ b/examples/custom-point-distribution/README.md @@ -17,7 +17,7 @@ It sets the following things in the Guild: - Basic data (its name, urlName, ...) - A role with a GUILD_SNAPSHOT requirement. This requirement will be the source of the point distribution -- A POINTS reward, which taks it's input from the requirement +- A POINTS reward, which takes its input from the requirement ## Editing the points