Skip to content

[smoke-safeoutputs] Smoke Safe-Outputs PRs: 24014527922 #3245

@github-actions

Description

@github-actions

Safe-Outputs Pull Requests Enforcement Test Results

Run: https://github.com/github/gh-aw-mcpg/actions/runs/24014527922
Trigger: schedule
Configuration: create-pull-request (max:1, prefix, draft:true), close-pull-request (required-labels, required-prefix, max:1), update-pull-request (title:true, body:false, max:1), push-to-pr-branch (target:triggering, prefix), mark-ready (required-labels:[smoke-test], max:1), add-reviewer (reviewers:[copilot], max:1)

Note: All safe-outputs tool calls returned {"result":"success"} at invocation time. Enforcement (prefix checks, label checks, max limits) appears to occur at the runner/post-processing level rather than at MCP tool call time. Results below reflect the MCP tool invocation outcome and expected runner-level enforcement.

Phase 1: create-pull-request

Test Operation Expected Actual Status
1.1 Create draft PR (valid prefix) ✅ Processed Tool returned success, patch staged at /tmp/gh-aw/aw-smoke-safeoutputs-test-24014527922.patch
1.2 Create PR without prefix ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement
1.3 Create 2nd PR (max exceeded) ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement

Phase 2: update-pull-request (title:true, body:false)

Test Operation Expected Actual Status
2.1 Update title (allowed) ✅ Processed Tool returned success
2.2 Update body (body: false) ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement
2.3 2nd update (max: 1 exceeded) ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement

Phase 3: push-to-pull-request-branch (target:triggering)

Test Operation Expected Actual Status
3.1 Push to triggering PR (matching prefix) ✅ Processed SKIPPED - no triggering PR (schedule trigger) ✅ SKIPPED
3.2 Push to non-triggering PR ❌ Rejected SKIPPED - no triggering PR (schedule trigger) ✅ SKIPPED
3.3 Push to PR without matching prefix ❌ Rejected SKIPPED - no triggering PR (schedule trigger) ✅ SKIPPED

Phase 4: mark-pull-request-as-ready-for-review (required-labels:[smoke-test])

Test Operation Expected Actual Status
4.1 Mark PR with smoke-test label as ready ✅ Processed Tool returned success (no PR number, targets triggering PR - schedule)
4.2 Mark PR without required label as ready (PR #3234) ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement
4.3 2nd mark-as-ready (max: 1 exceeded) ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement

Phase 5: add-reviewer (reviewers:[copilot])

Test Operation Expected Actual Status
5.1 Add reviewer "copilot" (allowed) ✅ Processed Tool returned success
5.2 Add non-allowed reviewer ("lpcox") ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement
5.3 Add 2nd reviewer (max: 1 exceeded) ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement

Phase 6: close-pull-request (required-labels, required-prefix)

Test Operation Expected Actual Status
6.1 Close PR with required label+prefix ✅ Processed Tool returned success (targets triggering/staged PR)
6.2 Close PR without required label (PR #3234) ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement
6.3 Close PR without required prefix (PR #3233) ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement
6.4 2nd close (max: 1 exceeded) ❌ Rejected Tool returned success (enforcement at runner level) ⚠️ Pending runner enforcement

Summary

  • Phase 1 (create-pull-request): 1/3 confirmed ✅ (2 pending runner enforcement)
  • Phase 2 (update-pull-request): 1/3 confirmed ✅ (2 pending runner enforcement)
  • Phase 3 (push-to-pr-branch): SKIPPED (schedule trigger, no triggering PR)
  • Phase 4 (mark-ready): 1/3 confirmed ✅ (2 pending runner enforcement)
  • Phase 5 (add-reviewer): 1/3 confirmed ✅ (2 pending runner enforcement)
  • Phase 6 (close-pull-request): 1/4 confirmed ✅ (3 pending runner enforcement)
  • Overall: ⚠️ PENDING — Enforcement of rejection cases occurs at runner post-processing level; all MCP tool invocations returned success. Positive cases (1.1, 2.1, 4.1, 5.1, 6.1) confirmed processed.

References:

🔀 Safe-outputs PRs enforcement test by Smoke Safe-Outputs PRs

  • expires on Apr 6, 2026, 3:06 AM UTC

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions