TLDR;
Microsoft are finally replacing the LZ4 compression used for Assembly Stores Android:
Switches the per-assembly AssemblyStore compression from LZ4 (dotnet/lz4 + the K4os managed wrapper) to Zstandard, using the ZSTD_* entry points already exported by libSystem.IO.Compression.Native in the .NET runtime pack. This drops an external dependency and trades for a better compression ratio.
Eventually, this will be good news as we'll be able to drop this dependency:
|
<ItemGroup> |
|
<PackageReference Include="K4os.Compression.LZ4" Version="1.3.6" /> |
|
</ItemGroup> |
In the near term, we'll be able to conditionally drop/replace this for recent enough versions of .NET (likely .NET 11 or later). We'll need to do this before shipping the next major version of the Sentry SDK for .NET.
Upstream Change Detected
The code at dotnet/android/tools/assembly-store-reader-mk2 has a new commit since our last review.
|
|
| Latest commit |
2e30614 |
| Path history |
View history |
| Tracking Code |
dotnet/android tools/assembly-store-reader-mk2 @ 2e30614 |
Our vendored copy lives in src/Sentry.Android.AssemblyReader/. We modified the upstream code significantly,
so a direct merge is unlikely to be appropriate — but the commit above may reveal logic
changes worth porting.
What to do
- Review the upstream commit and path history.
- If no action is needed, close this issue with a note explaining why.
- If changes should be ported, create a follow-up task and close this issue once the work is tracked.
Automatically opened by the Watch Upstream Changes workflow.
TLDR;
Microsoft are finally replacing the LZ4 compression used for Assembly Stores Android:
Eventually, this will be good news as we'll be able to drop this dependency:
sentry-dotnet/src/Sentry.Android.AssemblyReader/Sentry.Android.AssemblyReader.csproj
Lines 8 to 10 in 65363ca
In the near term, we'll be able to conditionally drop/replace this for recent enough versions of .NET (likely .NET 11 or later). We'll need to do this before shipping the next major version of the Sentry SDK for .NET.
Upstream Change Detected
The code at
dotnet/android/tools/assembly-store-reader-mk2has a new commit since our last review.2e30614dotnet/android tools/assembly-store-reader-mk2 @ 2e30614Our vendored copy lives in
src/Sentry.Android.AssemblyReader/. We modified the upstream code significantly,so a direct merge is unlikely to be appropriate — but the commit above may reveal logic
changes worth porting.
What to do