Skip to content

Fix: Update firebase.json change codebase name - #1280

Closed
vyolla wants to merge 1 commit into
firebase:mainfrom
vyolla:main
Closed

vyolla wants to merge 1 commit into
firebase:mainfrom
vyolla:main

Conversation

@vyolla

@vyolla vyolla commented Apr 29, 2026

Copy link
Copy Markdown

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the codebase name in the Firebase configuration. The reviewer suggests using a more unique codebase name to avoid potential naming collisions when deploying multiple samples, recommending the addition of a source property instead.

{
"functions": {
"codebase": "http-flask"
"codebase": "functions"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a generic codebase name like "functions" can lead to naming collisions if a user attempts to deploy multiple samples from this repository to the same Firebase project. It is better to use a unique codebase name, such as "http-flask", and explicitly specify the source directory using the "source" property. This ensures that the Firebase CLI can correctly locate the functions code while maintaining a distinct identity for this sample's functions.

    "codebase": "http-flask",
    "source": "functions"

@jhuleatt

jhuleatt commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR, Bruno! The samples here name their functions codebase after the sample directory (Python/thumbnails is thumbnails, Python/http-flask is http-flask), so when you deploy several samples into one project, one sample's deploy doesn't offer to delete another sample's functions. http-flask is a valid codebase name and nothing in the README depends on it, so I'm closing this to keep the samples consistent. If the current name gave you an error, paste the CLI output and firebase --version here and I'll reopen and fix the real problem.

@jhuleatt jhuleatt closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants