Skip to content

Commit ec8da23

Browse files
committed
Duplicate method to untangle dependency
We *could* have added a helper class, but it’s a lot of boilerplate for a single, simple method.
1 parent 70715ce commit ec8da23

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

‎java/src/test/java/org/rocksdb/SharedTempFileLoaderTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ static BufferedReader mockContentReader() {
2929
return new BufferedReader(new InputStreamReader(is));
3030
}
3131

32-
static void compare(BufferedReader expected, BufferedReader actual) throws IOException {
32+
static private void compare(BufferedReader expected, BufferedReader actual) throws IOException {
3333
String expectedLine = expected.readLine();
3434
String actualLine = actual.readLine();
3535
while (expectedLine != null) {

‎java/src/test/java/org/rocksdb/SharedTempFileMockMain.java‎

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.rocksdb;
22

33
import static org.assertj.core.api.Assertions.assertThat;
4-
import static org.rocksdb.SharedTempFileLoaderTest.compare;
54

65
import java.io.BufferedReader;
76
import java.io.IOException;
@@ -45,4 +44,15 @@ public static void main(final String[] args) throws IOException, InterruptedExce
4544

4645
Thread.sleep(2000);
4746
}
47+
48+
static private void compare(BufferedReader expected, BufferedReader actual) throws IOException {
49+
String expectedLine = expected.readLine();
50+
String actualLine = actual.readLine();
51+
while (expectedLine != null) {
52+
assertThat(actualLine).isEqualTo(expectedLine);
53+
expectedLine = expected.readLine();
54+
actualLine = actual.readLine();
55+
}
56+
assertThat(actualLine).isNull();
57+
}
4858
}

0 commit comments

Comments
 (0)