Skip to content

Commit e95028d

Browse files
authored
Merge pull request #590 from derek73/fix/stale-jr-title-comment
fix: correct the stale 'jr is title vocabulary' comment in script_segment
2 parents 2f7a044 + afccc47 commit e95028d

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

‎nameparser/_pipeline/_script_segment.py‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -730,11 +730,13 @@ def script_segment(state: ParseState) -> ParseState:
730730
# rather than splitting -- a different mechanism, and no peel
731731
# site either way. A glued Latin POST-nominal is spelled the
732732
# same way, so it reaches that same mechanism rather than
733-
# nothing: period_joined_vocab reads "Smith.Jr." as a title
734-
# ('jr' is title vocabulary as well as suffix vocabulary), and
735-
# where position allows, that wins -- "Smith.Jr. Anderson"
736-
# gives title "Smith.Jr.", family "Anderson". Whatever it
737-
# decides, this bail is what settles the question here: it
733+
# nothing: period_joined_vocab reads "Smith.Jr." as a suffix
734+
# ('jr' is suffix vocabulary only since #296 took it out of
735+
# TITLES), and position decides whether that reading lands --
736+
# "John Anderson Smith.Jr." gives suffix "Smith.Jr.", while
737+
# "Smith.Jr. Anderson" gives given "Smith.Jr.", family
738+
# "Anderson" (measured 2026-10-02). Whatever it decides, this
739+
# bail is what settles the question here: it
738740
# returns above all of it, so no ASCII input reaches the peel.
739741
return state
740742
if not state.segments:

0 commit comments

Comments
 (0)