Repository navigation
Commit 2a52a55
Word a report's field from the word's final role (#626)
Five of assign's reports named the field their word was read into
from the role it held at assign, and two later rules still move a
word: H1 takes a lone unit behind a title into the family, and P6's
attachment takes a trailing name word into the family at the end of
a name read family-first. So `Attorney General of Minnesota` said
'General of Minnesota' was "read as a given name" (since 2.3.0), and
`Kim Min Do` under FAMILY_FIRST said 'Do' was "read as a middle
name", each with the word in the family.
The decision stays at its site; the field's wording moves to
assemble, which alone knows final roles. An emitter naming a field
writes its sentence up to the field and passes the rest as
PendingAmbiguity.field_tail; assemble joins them around FIELD_READING
of the first referent's final role. All five emitters use it.
Measured on master over 51,835 names under all three orders: 2,689 of
66,208 field claims named the wrong field; on the tree, 0. No role,
kind, initials or rendering moves on the fingerprint; 40 details
change, all title-or-name 'given' -> 'family'. Guarded by
test_a_report_names_the_field_its_word_lands_in over every case row
under all three orders (control: 10 failures on master).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent 26cdb89 commit 2a52a55
11 files changed
Lines changed: 180 additions & 60 deletions
File tree
- docs
- design
- nameparser/_pipeline
- tests/v2
- pipeline
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2429 | 2429 | | |
2430 | 2430 | | |
2431 | 2431 | | |
2432 | | - | |
| 2432 | + | |
| 2433 | + | |
| 2434 | + | |
2433 | 2435 | | |
2434 | 2436 | | |
2435 | 2437 | | |
| |||
2439 | 2441 | | |
2440 | 2442 | | |
2441 | 2443 | | |
2442 | | - | |
| 2444 | + | |
2443 | 2445 | | |
2444 | 2446 | | |
2445 | 2447 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
21 | | - | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
112 | 113 | | |
113 | 114 | | |
114 | 115 | | |
115 | | - | |
116 | | - | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
117 | 121 | | |
118 | 122 | | |
119 | 123 | | |
0 commit comments