fix ci

Author: IOBYTE

.github/workflows/selfcheck.yml

@@ -121,7 +121,7 @@ jobs:
 
       - name: Self check (unusedFunction / no test / no gui)
         run: |
-          supprs="--suppress=unusedFunction:lib/errorlogger.h:197 --suppress=unusedFunction:lib/importproject.cpp:1671 --suppress=unusedFunction:lib/importproject.cpp:1695"
+          supprs="--suppress=unusedFunction:lib/errorlogger.h:197 --suppress=unusedFunction:lib/importproject.cpp:1695 --suppress=unusedFunction:lib/importproject.cpp:1719"
           ./cppcheck -q --template=selfcheck --error-exitcode=1 --library=cppcheck-lib -D__CPPCHECK__ -D__GNUC__ --enable=unusedFunction,information --exception-handling -rp=. --project=cmake.output.notest_nogui/compile_commands.json --suppressions-list=.selfcheck_unused_suppressions --inline-suppr $supprs
         env:
           DISABLE_VALUEFLOW: 1

lib/importproject.cpp

@@ -543,33 +543,36 @@ bool ImportProject::importSlnx(const std::string& filename, const std::vector<st
     auto processProject = [&](const tinyxml2::XMLElement* projectNode) {
         const char* pathAttribute = projectNode->Attribute("Path");
         if (pathAttribute == nullptr)
-            return;
+            return true;
 
         std::string vcxproj(pathAttribute);
         vcxproj = Path::toNativeSeparators(std::move(vcxproj));
 
         if (Path::getFilenameExtensionInLowerCase(vcxproj) != ".vcxproj")
-            return; // skip other project types
+            return true; // skip other project types
 
         if (!Path::isAbsolute(vcxproj))
             vcxproj = variables["SolutionDir"] + vcxproj;
 
         vcxproj = Path::fromNativeSeparators(std::move(vcxproj));
         if (!importVcxproj(vcxproj, variables, "", fileFilters, sharedItemsProjects)) {
             errors.emplace_back("failed to load '" + vcxproj + "' from Visual Studio solution");
-            return;
+            return false;
         }
         found = true;
+        return true;
     };
 
     for (const tinyxml2::XMLElement* node = rootnode->FirstChildElement(); node; node = node->NextSiblingElement()) {
         const char* name = node->Name();
         if (std::strcmp(name, "Project") == 0) {
-            processProject(node);
+            if (!processProject(node))
+                return false;
         } else if (std::strcmp(name, "Folder") == 0) {
             for (const tinyxml2::XMLElement* childNode = node->FirstChildElement(); childNode; childNode = childNode->NextSiblingElement()) {
                 if (std::strcmp(childNode->Name(), "Project") == 0) {
-                    processProject(childNode);
+                    if (!processProject(childNode))
+                        return false;
                 }
             }
         }