sonarcube cloud

Author: dominikzogg

src/FloatToString.php

@@ -20,11 +20,9 @@ public static function floatToString(float $value): string
             return INF === $value ? 'Infinity' : '-Infinity';
         }
 
-        if (0.0 === $value) {
-            return '0';
-        }
+        $sign = $value < 0 ? '-' : '';
 
-        return ($value < 0 ? '-' : '').self::formatAbsolute(abs($value));
+        return 0.0 === $value ? '0' : $sign.self::formatAbsolute(abs($value));
     }
 
     private static function formatAbsolute(float $value): string
@@ -50,11 +48,9 @@ private static function formatAbsolute(float $value): string
         $pointPosition = (int) $exponent + 1;
 
         // fixed notation between 1e-6 and 1e21, exponential notation beyond
-        if (-6 < $pointPosition && $pointPosition <= 21) {
-            return self::fixedNotation($digits, $pointPosition);
-        }
-
-        return self::exponentialNotation($digits, $pointPosition - 1);
+        return -6 < $pointPosition && $pointPosition <= 21
+            ? self::fixedNotation($digits, $pointPosition)
+            : self::exponentialNotation($digits, $pointPosition - 1);
     }
 
     private static function fixedNotation(string $digits, int $pointPosition): string

tests/Unit/Test262ArrayPrototypeEveryTest.php

@@ -1003,7 +1003,6 @@ public function test1544167CII4(): void
     {
         $arr = new Arr(0, 1, 2, 3, 4, 5);
         $lastIdx = 0;
-        $called = 0;
 
         $callbackfn = static function (int $val, int $idx) use (&$lastIdx, &$called): bool {
             ++$called;

tests/Unit/Test262ArrayPrototypeFindIndexTest.php

@@ -113,8 +113,6 @@ public function testPredicateCallParameters(): void
      */
     public function testPredicateCallThisNonStrict(): void
     {
-        $result = null;
-
         Arr::of(1)->findIndex(function () use (&$result) {
             $result = $this;
 

tests/Unit/Test262ArrayPrototypeFindLastIndexTest.php

@@ -115,8 +115,6 @@ public function testPredicateCallParameters(): void
      */
     public function testPredicateCallThisNonStrict(): void
     {
-        $result = null;
-
         Arr::of(1)->findLastIndex(function () use (&$result) {
             $result = $this;
 

tests/Unit/Test262ArrayPrototypeFindLastTest.php

@@ -115,8 +115,6 @@ public function testPredicateCallParameters(): void
      */
     public function testPredicateCallThisNonStrict(): void
     {
-        $result = null;
-
         Arr::of(1)->findLast(function () use (&$result) {
             $result = $this;
 

tests/Unit/Test262ArrayPrototypeFindTest.php

@@ -113,8 +113,6 @@ public function testPredicateCallParameters(): void
      */
     public function testPredicateCallThisNonStrict(): void
     {
-        $result = null;
-
         Arr::of(1)->find(function () use (&$result) {
             $result = $this;
 

tests/Unit/Test262ArrayPrototypeForEachTest.php

@@ -267,7 +267,6 @@ public function test15441851(): void
     {
         // Adapted: when thisArg is not passed a non-static Closure keeps its original
         // $this (the JS test expects the global object rather than a local binding).
-        $result = null;
 
         $callbackfn = function () use (&$result): void {
             $result = $this;
@@ -1053,7 +1052,6 @@ public function test1544187Cii4(): void
     {
         $arr = new Arr(0, 1, 2, 3, 4, 5);
         $lastIdx = 0;
-        $called = 0;
         $result = true;
 
         $callbackfn = static function (mixed $val, int $idx) use (&$lastIdx, &$called, &$result): void {

tests/Unit/Test262ArrayPrototypeMapTest.php

@@ -1027,7 +1027,6 @@ public function test1544198CII4(): void
     {
         $arr = new Arr(0, 1, 2, 3, 4, 5);
         $lastIdx = 0;
-        $called = 0;
         $result = true;
 
         $callbackfn = static function (int $val, int $idx) use (&$lastIdx, &$called, &$result): void {

tests/Unit/Test262ArrayPrototypeSomeTest.php

@@ -939,7 +939,6 @@ public function test1544177CII4(): void
     {
         $arr = new Arr(0, 1, 2, 3, 4, 5);
         $lastIdx = 0;
-        $called = 0;
 
         $callbackfn = static function (int $val, int $idx) use (&$lastIdx, &$called): bool {
             ++$called;

tests/Unit/Test262MapPrototypeGetOrInsertComputedTest.php

@@ -161,7 +161,6 @@ public function testCheckCallbackFnArgs(): void
     {
         $map = new Map();
 
-        $args = null;
         $map->getOrInsertComputed(1, static function (mixed ...$receivedArgs) use (&$args): void {
             $args = $receivedArgs;
         });